1418869 - WebRenderImageData::UpdateImageKey is slow

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Ethan Lin[:ethlin]]

Gecko profiler link: https://perfht.ml/2hwBjdL

We copy the buffer in GetAsSourceSurface[1] when the image is a TextureWrapperImage. For fallback items, we shouldn't try to share them.

[1] https://dxr.mozilla.org/mozilla-central/rev/a3f183201f7f183c263d554bfb15fbf0b0ed2ea4/gfx/layers/ipc/SharedSurfacesChild.cpp#258

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Bug 1418869 - Do not try to share the fallback images.

The flag of force update is only for fallback items. Fallback items can't share the images with other items.
So I replace 'aForceUpdate' with 'aFallback' and remove some unnecessary checks.

Review commit: https://reviewboard.mozilla.org/r/201120/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201120/

Comment 2

[Ethan Lin[:ethlin]]

According to the gecko profiler, 22% of the RenderLayer is in WebRenderImageData::UpdateImageKey.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8929960 [details]
Bug 1418869 - Do not try to share the fallback images.

https://reviewboard.mozilla.org/r/201120/#review206326

Nice catch. I did not consider how expensive GetAsSourceSurface could be for some types.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec7ff1ef12d3
Do not try to share the fallback images. r=aosmond

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/ec7ff1ef12d3