Closed Bug 1418869 Opened 2 years ago Closed 2 years ago
Render Image Data::Update Image Key is slow
59 bytes, text/x-review-board-request
Gecko profiler link: https://perfht.ml/2hwBjdL We copy the buffer in GetAsSourceSurface when the image is a TextureWrapperImage. For fallback items, we shouldn't try to share them.  https://dxr.mozilla.org/mozilla-central/rev/a3f183201f7f183c263d554bfb15fbf0b0ed2ea4/gfx/layers/ipc/SharedSurfacesChild.cpp#258
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
According to the gecko profiler, 22% of the RenderLayer is in WebRenderImageData::UpdateImageKey.
Comment on attachment 8929960 [details] Bug 1418869 - Do not try to share the fallback images. https://reviewboard.mozilla.org/r/201120/#review206326 Nice catch. I did not consider how expensive GetAsSourceSurface could be for some types.
Attachment #8929960 - Flags: review?(aosmond) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ec7ff1ef12d3 Do not try to share the fallback images. r=aosmond
You need to log in before you can comment on or make changes to this bug.