1418885 - [Form Autofill] The second record can't be saved if it contains any empty computed fields

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P1)

Description

[Luke Chang [:lchang] (inactive)]

[Steps:]

1. Go to the "Privacy & Security panel" in about:preferences and click "Saved Addresses..." under "Forms & Passwords". Remove all address records if any.
2. Open the demo page: https://luke-chang.github.io/autofill-demo/autocomplete-all.html
3. Fill in "given-name", "family-name", "organization", "street-address" with any data (e.g. A, B, C, D)
4. Click Submit button and dismiss the doorhanger if any
5. Reopen the same demo page (it should be already there)
6. Fill in "given-name", "family-name", "organization", "street-address" with any data different from step 2 (e.g. 1, 2, 3, 4)
7. Click Submit button again
8. Go to the "Privacy & Security panel" in about:preferences and click "Saved Addresses..." under "Forms & Passwords"


[Actual Result:]
Only the first record were saved.

[Expected Result:]
There should be two records saved.

Comment 1

[Luke Chang [:lchang] (inactive)]

It's a regression caused by bug 1415451.

Comment 2

[Luke Chang [:lchang] (inactive)]

Attachment: Bug 1418885 - [Form Autofill] Ensure all computed fields are removed after normalizing and strip trailing newlines in "street-address".

Review commit: https://reviewboard.mozilla.org/r/201180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201180/

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8929991 [details]
Bug 1418885 - [Form Autofill] Ensure all computed fields are removed after normalizing and strip trailing newlines in "street-address".

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201180/diff/1-2/

Comment 4

[Steve Chung [:steveck]]

Comment on attachment 8929991 [details]
Bug 1418885 - [Form Autofill] Ensure all computed fields are removed after normalizing and strip trailing newlines in "street-address".

https://reviewboard.mozilla.org/r/201180/#review206294

LGTM, thanks

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/589acfe789d8
[Form Autofill] Ensure all computed fields are removed after normalizing and strip trailing newlines in "street-address". r=steveck

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/589acfe789d8

Comment 7

[mandercs3]

Attachment: Bug 1418885 - [Form Autofill] Ensure all computed fields are removed after normalizing and strip trailing newlines in "street-address".

Review commit: https://reviewboard.mozilla.org/r/207020/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207020/

Comment 8

[Steve Chung [:steveck]]

Comment on attachment 8936262 [details]
Bug 1418885 - [Form Autofill] Ensure all computed fields are removed after normalizing and strip trailing newlines in "street-address".

https://reviewboard.mozilla.org/r/207020/#review213034

Comment 9

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to reproduce this issue on Firefox 59.0a1 (2017-11-19), under Windows 10x64.
The issue is no longer reproducible on Firefox 60.0a1 (2018-02-02), or on Firefox 59.0b6.
Tests were performed under Windows 10x64, Ubuntu 16.04x32, MacOS 10.10.5.