Closed Bug 1418885 Opened 3 years ago Closed 3 years ago

[Form Autofill] The second record can't be saved if it contains any empty computed fields

Categories

(Toolkit :: Form Autofill, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla59
Tracking Status
firefox58 --- unaffected
firefox59 --- verified
firefox60 --- verified

People

(Reporter: lchang, Assigned: lchang)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

[Steps:]

1. Go to the "Privacy & Security panel" in about:preferences and click "Saved Addresses..." under "Forms & Passwords". Remove all address records if any.
2. Open the demo page: https://luke-chang.github.io/autofill-demo/autocomplete-all.html
3. Fill in "given-name", "family-name", "organization", "street-address" with any data (e.g. A, B, C, D)
4. Click Submit button and dismiss the doorhanger if any
5. Reopen the same demo page (it should be already there)
6. Fill in "given-name", "family-name", "organization", "street-address" with any data different from step 2 (e.g. 1, 2, 3, 4)
7. Click Submit button again
8. Go to the "Privacy & Security panel" in about:preferences and click "Saved Addresses..." under "Forms & Passwords"


[Actual Result:]
Only the first record were saved.

[Expected Result:]
There should be two records saved.
It's a regression caused by bug 1415451.
Summary: [Form Autofill] The second address record can't be saved if it contains any computed fields → [Form Autofill] The second record can't be saved if it contains any empty computed fields
Comment on attachment 8929991 [details]
Bug 1418885 - [Form Autofill] Ensure all computed fields are removed after normalizing and strip trailing newlines in "street-address".

https://reviewboard.mozilla.org/r/201180/#review206294

LGTM, thanks
Attachment #8929991 - Flags: review?(schung) → review+
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/589acfe789d8
[Form Autofill] Ensure all computed fields are removed after normalizing and strip trailing newlines in "street-address". r=steveck
https://hg.mozilla.org/mozilla-central/rev/589acfe789d8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment on attachment 8936262 [details]
Bug 1418885 - [Form Autofill] Ensure all computed fields are removed after normalizing and strip trailing newlines in "street-address".

https://reviewboard.mozilla.org/r/207020/#review213034
Attachment #8936262 - Flags: review?(schung)
I managed to reproduce this issue on Firefox 59.0a1 (2017-11-19), under Windows 10x64.
The issue is no longer reproducible on Firefox 60.0a1 (2018-02-02), or on Firefox 59.0b6.
Tests were performed under Windows 10x64, Ubuntu 16.04x32, MacOS 10.10.5.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.