Closed Bug 1418905 Opened 3 years ago Closed 3 years ago

Move nsRuleNode::ComputeComputedCalc() and nsRuleNode::ComputeCoordPercentCalc() to nsStyleCoord

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(2 files)

Bug 1418905 - Move nsRuleNode::ComputeComputedCalc() into nsStyleCoord.
59 bytes, text/x-review-board-request
heycam
: review+
Details
Bug 1418905 - Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord.
59 bytes, text/x-review-board-request
heycam
: review+
Details 
These funcitions are needed after removing old gecko style system.
Comment on attachment 8929997 [details]
Bug 1418905 - Move nsRuleNode::ComputeComputedCalc() into nsStyleCoord.

https://reviewboard.mozilla.org/r/201184/#review206302
Attachment #8929997 - Flags: review?(cam) → review+
Comment on attachment 8929998 [details]
Bug 1418905 - Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord.

https://reviewboard.mozilla.org/r/201186/#review206304

Patch looks good but you have a bunch of test failures so I guess I overlooked something. :-)
Attachment #8929998 - Flags: review?(cam) → review+
Comment on attachment 8929998 [details]
Bug 1418905 - Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord.

https://reviewboard.mozilla.org/r/201186/#review206304

Oh. That's because I added `MOZ_ASSERT(aPercentageBasis != NS_UNCONSTRAINEDSIZE)`, and `ComputeCoordPercentCalc(nscoord_MAX)` will assert ...
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8e5435c7348
Move nsRuleNode::ComputeComputedCalc() into nsStyleCoord. r=heycam
https://hg.mozilla.org/integration/autoland/rev/9ed32ea09c9d
Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord. r=heycam
https://hg.mozilla.org/mozilla-central/rev/a8e5435c7348
https://hg.mozilla.org/mozilla-central/rev/9ed32ea09c9d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.