1418905 - Move nsRuleNode::ComputeComputedCalc() and nsRuleNode::ComputeCoordPercentCalc() to nsStyleCoord

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

These funcitions are needed after removing old gecko style system.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1418905 - Move nsRuleNode::ComputeComputedCalc() into nsStyleCoord.

Review commit: https://reviewboard.mozilla.org/r/201184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201184/

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1418905 - Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord.

Review commit: https://reviewboard.mozilla.org/r/201186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201186/

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8929997 [details]
Bug 1418905 - Move nsRuleNode::ComputeComputedCalc() into nsStyleCoord.

https://reviewboard.mozilla.org/r/201184/#review206302

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8929998 [details]
Bug 1418905 - Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord.

https://reviewboard.mozilla.org/r/201186/#review206304

Patch looks good but you have a bunch of test failures so I guess I overlooked something. :-)

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8929998 [details]
Bug 1418905 - Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord.

https://reviewboard.mozilla.org/r/201186/#review206304

Oh. That's because I added `MOZ_ASSERT(aPercentageBasis != NS_UNCONSTRAINEDSIZE)`, and `ComputeCoordPercentCalc(nscoord_MAX)` will assert ...

Comment 6

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8929997 [details]
Bug 1418905 - Move nsRuleNode::ComputeComputedCalc() into nsStyleCoord.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201184/diff/1-2/

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8929998 [details]
Bug 1418905 - Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201186/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8e5435c7348
Move nsRuleNode::ComputeComputedCalc() into nsStyleCoord. r=heycam
https://hg.mozilla.org/integration/autoland/rev/9ed32ea09c9d
Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord. r=heycam

Comment 9

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/a8e5435c7348
https://hg.mozilla.org/mozilla-central/rev/9ed32ea09c9d