Closed
Bug 1418905
Opened 5 years ago
Closed 5 years ago
Move nsRuleNode::ComputeComputedCalc() and nsRuleNode::ComputeCoordPercentCalc() to nsStyleCoord
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(2 files)
These funcitions are needed after removing old gecko style system.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8929997 [details] Bug 1418905 - Move nsRuleNode::ComputeComputedCalc() into nsStyleCoord. https://reviewboard.mozilla.org/r/201184/#review206302
Attachment #8929997 -
Flags: review?(cam) → review+
|
|
||
Comment 4•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8929998 [details] Bug 1418905 - Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord. https://reviewboard.mozilla.org/r/201186/#review206304 Patch looks good but you have a bunch of test failures so I guess I overlooked something. :-)
Attachment #8929998 -
Flags: review?(cam) → review+
|
Assignee | |
Comment 5•5 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8929998 [details] Bug 1418905 - Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord. https://reviewboard.mozilla.org/r/201186/#review206304 Oh. That's because I added `MOZ_ASSERT(aPercentageBasis != NS_UNCONSTRAINEDSIZE)`, and `ComputeCoordPercentCalc(nscoord_MAX)` will assert ...
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a8e5435c7348 Move nsRuleNode::ComputeComputedCalc() into nsStyleCoord. r=heycam https://hg.mozilla.org/integration/autoland/rev/9ed32ea09c9d Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord. r=heycam
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a8e5435c7348 https://hg.mozilla.org/mozilla-central/rev/9ed32ea09c9d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•