Closed Bug 1418918 Opened 2 years ago Closed 2 years ago

Tighten up assertions in MediaCache

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

This makes it easier to identify functions that are running on the main thread and they will be candidates to be moved off the main tread.
Assignee: nobody → jwwang
Blocks: 1369263
Priority: -- → P3
Attachment #8932003 - Flags: review?(bechen)
Attachment #8932004 - Flags: review?(bechen)
Comment on attachment 8932003 [details]
Bug 1418918. P1 - remove unused FlushPartialBlock().

https://reviewboard.mozilla.org/r/203052/#review208332
Attachment #8932003 - Flags: review?(bechen) → review+
Comment on attachment 8932004 [details]
Bug 1418918. P2 - add thread/monitor assertions.

https://reviewboard.mozilla.org/r/203054/#review208336
Attachment #8932004 - Flags: review?(bechen) → review+
Attachment #8932003 - Flags: review?(gsquelart)
Attachment #8932004 - Flags: review?(gsquelart)
Comment on attachment 8932003 [details]
Bug 1418918. P1 - remove unused FlushPartialBlock().

https://reviewboard.mozilla.org/r/203052/#review208346
Attachment #8932003 - Flags: review?(gsquelart) → review+
Comment on attachment 8932004 [details]
Bug 1418918. P2 - add thread/monitor assertions.

https://reviewboard.mozilla.org/r/203054/#review208348
Attachment #8932004 - Flags: review?(gsquelart) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/89b125e739e4
P1 - remove unused FlushPartialBlock(). r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/7358a7b7676b
P2 - add thread/monitor assertions. r=bechen,gerald
https://hg.mozilla.org/mozilla-central/rev/89b125e739e4
https://hg.mozilla.org/mozilla-central/rev/7358a7b7676b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.