1418929 - g2/DAMP tests are not displayed on PerfHerder/compare page

Status: RESOLVED INVALID

(Tree Management :: Perfherder, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

The following try run seems to have valid PERFHERDER_DATA json in logs:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8b73c71ba03ed18b87b1122e9f4ef982b8e42a9
(i.e. this run has nothing special, it should work)

But its results aren't displayed on PerfHerder compare page:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=a8b73c71ba03ed18b87b1122e9f4ef982b8e42a9&framework=1&selectedTimeRange=172800

Comment 1

[Alexandre Poirot [:ochameau]]

Just to be clear, this is not specific to this run, all DAMP/g2 tests are broken and we can't see the results:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=7257b531e255d547989a670834b115f454ffc227&framework=1&selectedTimeRange=172800

https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=c03e0adb30d0672ac8b70411ecfa5ea9a4e49a1e&framework=1&selectedTimeRange=86400

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

this seems to be an issue with comparing to a branch, not a specific revision- more investigation is needed when I am at work in the morning.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I see more of the problem, what appears to happen here is that we have a default range of '2 days', and that applies to the age of the try push as well, not just the base branch (defaults to mozilla-central).

I think the fix here is to only apply the '2 days' to the base branch and show the results of a try push no matter what.  This seems valid as often we analyze a push from last week, rarely it seems that a push is >10 days old, typically 2-7 days old.

Comment 4

[Alexandre Poirot [:ochameau]]

Last X days only applies for when you compare with a branch. I don't quite follow what it means to apply that to a given revision?

> I think the fix here is to only apply the '2 days' to the base branch and
> show the results of a try push no matter what.  

I agree with that sentence.

> This seems valid as often we analyze a push from last week, rarely it seems that a push is >10 days old,
> typically 2-7 days old.

But I don't quite follow this one (for the record, I original requested this special behavior in bug 1408912).
It can be very misleading to see the try results change depending on when you open it.
We can easily refer to a try push older than 10 days in bugs.

Comment 5

[Ionuț Goldan [:igoldan]]

Hi, Alexandre! Can you please check if you still experience this issue?
The initial links aren't of much use now, because the associated data has been expired (deleted). Thanks!

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

iirc damp tests are in their own 'harness', so you would need to filter on damp, not on talos or raptor.

Comment 7

[Alexandre Poirot [:ochameau]]

I have no idea what this was all about!
I know that after a few of my report the behavior of "Last X days" changed, in order to track the last X days from the pushed revision date, instead of the last X days from "today" (which changes every day you open PerfHerder link ;)).
This edgecase may have disappeared when changing that?