141894 - Security button in msg compose needs a tooltip.

Status: VERIFIED FIXED

(MailNews Core :: Security, defect, P2)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID: Branch 2002-05-02. All OSs.

Summary: Security button in msg compose needs a tooltip.

Steps to Reproduce:

1. Open a compose window.
2. Hover over the 'Security' button.

Note the lack of a tooltip.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Assigned.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Patch, V1.

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Disclaimer: I'm unable to build PSM on my opt Mozilla build (or, just clueless).
 Can somebody try this patch and see if it works?  I've done lots of simple
DTD/XUL fixes and this should work.  Thanks.  Also note, the wording isn't final.  

Comment 4

[Kai Engert (:KaiE:)]

cc'ing cotter, who usually helps with security wordings. Sean, do you want to
have a look?

Technically patch looks fine to me.

Comment 5

[Sean Cotter]

Since you can also access message security info from here, I think the tooltip
should read as follows: "View or change security settings"

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Patch, V2

Made the wording changes to match Sean's comments.  Please review.  Thanks.

Comment 7

[Kai Engert (:KaiE:)]

Comment on attachment 82232 [details] [diff] [review]
Patch, V2

r=kaie

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 82232 [details] [diff] [review]
Patch, V2

sr=sspitzer

assuming that this same string doesn't appear in a .dtd file that we're already
including.

note, if you have plans to land on the branch, you'd need i18n permission from
mcarlson.

but if this is trunk only, you're ok.

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

C:\moz_src\mozilla\mailnews\extensions\smime\resources\content>cvs commit -m
"Bug 141894.  Security button in msgCompose should have a tooltip. 
r=[e-mail], sr=[e-mail]" msgCompSMIMEOverla
y.xul
Checking in msgCompSMIMEOverlay.xul;
/cvsroot/mozilla/mailnews/extensions/smime/resources/content/msgCompSMIMEOverlay.xul,v
 <--  msgCompSMIMEOverlay.xul
new revision: 1.7; previous revision: 1.6
done

C:\moz_src\mozilla\mailnews\extensions\smime\resources\locale\en-US>cvs commit
-m "Bug 141894.  Security button in msgCompose should have a tooltip. 
r=[e-mail], sr=[e-mail]" msgCompSMIMEO
verlay.dtd
Checking in msgCompSMIMEOverlay.dtd;
/cvsroot/mozilla/mailnews/extensions/smime/resources/locale/en-US/msgCompSMIMEOverlay.dtd,v
 <--  msgCompSMIMEOverlay.dtd
new revision: 1.6; previous revision: 1.5
done

Fixed on trunk, marking FIXED.

Comment 10

[John Unruh]

Verified on trunk

Comment 11

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on behalf ADT's behalf) for checkin to the 1.0 branch, pending
Driver's approval. Pls check this in before Tuesday morning.

Comment 12

[Kai Engert (:KaiE:)]

Comment on attachment 82232 [details] [diff] [review]
Patch, V2

Stephen forwarded me a message from chofmann, where he says
  a=chofmann for 1.0.1

Comment 13

[chris hofmann]

Comment on attachment 82232 [details] [diff] [review]
Patch, V2

a=chofmann for 1.0.1

Comment 14

[Kai Engert (:KaiE:)]

Checked in to branch

Comment 15

[John Unruh]

Verified on 6/3 Win2000 branch.