1418941 - remove stylo-disabled tests on trunk for osx and windows

Status: RESOLVED FIXED

(Testing :: General, enhancement)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: do not run stylo-disabled on osx or windows anymore

please take an extra minute or two to review this, since this will be landing on trunk, I expect it to ride the trains, not get uplifted to mozilla-beta.

Comment 2

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Comment on attachment 8930027 [details] [diff] [review]
do not run stylo-disabled on osx or windows anymore

Review of attachment 8930027 [details] [diff] [review]:
-----------------------------------------------------------------

This looks OK to me.

I ran it through 'mach taskgraph tasks | grep stylo-disabled'.

Why osx and windows but not linux?

There are also "windows-talos-stylo-disabled" and "macosx64-talos-stylo-disabled" sets, which look like they will continue to run. Is that what you want?

Are appropriate stakeholders aware of this change?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I discussing with :cpeterson, there are needs for coverage on stylo-disabled on linux until bug 1395112 is resolved.

thanks for pointing out the talos stylo-disabled, I will remove those and ask for another review.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: do not run stylo-disabled on osx or windows anymore

updated the patch to remove talos-stylo-disabled on osx/windows.  we still run stylo-disabled on everything linux right now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41c5160374dd
remove stylo-disabled tests on trunk for osx and windows. r=gbrown

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #3)
> I discussing with :cpeterson, there are needs for coverage on stylo-disabled
> on linux until bug 1395112 is resolved.

Yes. We want to continue testing stylo-disabled on Linux32 and Linux64. We're still using the old Gecko style system on Android and we run more tests on Linux desktop than on Android. We don't want to lose that test coverage of the old Gecko style system until we're confident we can ship Stylo on Android.

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/41c5160374dd