1418983 - Firefox themes cause close, minimise and maximise buttons to look awful

Status: NEW

(Firefox :: Theme, defect, P5)

Description

[Jed]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20171119220126

Steps to reproduce:

Put on any firefox theme from AMO.


Actual results:

The close, minimise and maximise buttons aren't the usual Windows 10 ones (normal ones: https://i.imgur.com/7fUnbiX.png), they are instead, these really ugly ones that stand out like a sore thumb: https://i.imgur.com/GA4sgiO.png


Expected results:

I would expect the same Windows 10 buttons be used, instead of these, or find a way to make them stand out less.

Comment 1

[Jed]

Just to add, because of how bad it looks, I just can't ever see myself using any themes, even though there are a few I am interested in using.

Comment 2

[Jed]

This is how Chrome does it, which fits in so much better: https://i.imgur.com/J17xysc.png & https://i.imgur.com/NXYsiFP.png

If it's to do with colouring and readability, a way around it could be to allow the theme author to set an accent colour for the titlebar and the buttons turn white or black for that accent colour, and the rest of the browser chrome below the titlebar and the tabs themselves could be allowed to textured/have an image or just an accent colour.

Comment 3

[Jim Mathies [:jimm]]

> https://i.imgur.com/GA4sgiO.png

These are themed buttons, who are you expecting something that isn't themed, when you're using a custom theme? I don't understand what your reporting here, can you please clarify the issue.

Comment 4

[Jed]

(In reply to Jim Mathies [:jimm] from comment #3)
> > https://i.imgur.com/GA4sgiO.png
> 
> These are themed buttons, who are you expecting something that isn't themed,
> when you're using a custom theme? I don't understand what your reporting
> here, can you please clarify the issue.

When applying themes on Windows 8.1 and below, their buttons stay the same. The same happens with MacOS. I don't see why Windows 10's buttons should be any different and change with a theme applied. They're still perfectly visible even with a theme, as Chrome's screenshots prove.

Comment 5

[thisuserisepic]

I can replicate this issue, however I am in agreement with Jim Mathies.

Comment 6

[thisuserisepic]

(In reply to thisuserisepic from comment #5)
> I can replicate this issue, however I am in agreement with Jim Mathies.

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0