Closed
Bug 1418989
Opened 7 years ago
Closed 16 days ago
ToValue should take an LBoxAllocation* argument instead of LIR + constant
Categories
(Core :: JavaScript Engine: JIT, enhancement, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
DUPLICATE
of bug 1944011
Tracking | Status | |
---|---|---|
firefox59 | --- | fix-optional |
People
(Reporter: jandem, Unassigned)
References
(Blocks 1 open bug)
Details
Realized this while reviewing bug 1407588. Right now we define a constant in the LIR instruction class, then pass that to ToValue, like this:
ValueOperand v = ToValue(lir, LMutateProto::ValueIndex);
Bug 1248007 added LBoxAllocation and made box allocations more like normal allocations. It would be nice if we added getBoxOperand, then we could for example add the following method to LMutateProto:
const LBoxAllocation* getValue() {
return getBoxOperand(ValueIndex); // or just 1 now
}
And in codegen, ToValue could just take this LBoxOperand* and then we no longer have to define/pass these constants.
Updated•7 years ago
|
status-firefox59:
--- → fix-optional
Priority: -- → P3
Updated•2 years ago
|
Severity: normal → S3
Reporter | ||
Comment 1•16 days ago
|
||
Bug 1944011 is doing this.
You need to log in
before you can comment on or make changes to this bug.
Description
•