Closed Bug 1418989 Opened 7 years ago Closed 16 days ago

ToValue should take an LBoxAllocation* argument instead of LIR + constant

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1944011
Tracking Status
firefox59 --- fix-optional

People

(Reporter: jandem, Unassigned)

References

(Blocks 1 open bug)

Details

Realized this while reviewing bug 1407588. Right now we define a constant in the LIR instruction class, then pass that to ToValue, like this: ValueOperand v = ToValue(lir, LMutateProto::ValueIndex); Bug 1248007 added LBoxAllocation and made box allocations more like normal allocations. It would be nice if we added getBoxOperand, then we could for example add the following method to LMutateProto: const LBoxAllocation* getValue() { return getBoxOperand(ValueIndex); // or just 1 now } And in codegen, ToValue could just take this LBoxOperand* and then we no longer have to define/pass these constants.
Priority: -- → P3
Severity: normal → S3

Bug 1944011 is doing this.

Status: NEW → RESOLVED
Closed: 16 days ago
Duplicate of bug: 1944011
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.