1419025 - Wasm baseline: Refactor registers and register allocation

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Lars T Hansen [:lth]]

Spun out from bug 1336027.

In order to reduce complexity in the BaseCompiler class, mve the register abstraction classes and the register allocator class out of the BaseCompiler.

Comment 1

[Lars T Hansen [:lth]]

Attachment: bug1419025-refactor-regalloc.patch

Patch.  Carry bbouvier's r+ from bug 1336027 comment 17.

Remarks in that comment *NOT* yet addressed here.

Also, discussion elsewhere revealed that while there are effectively all sorts of tests for atomic load and store rolled in with the test cases of non-atomic load and store (since they use the same code generators), this is *NOT* true for 64-bit atomic load and store on 32-bit systems, where completely different code paths are used.  So would be nice to have additional tests for those.

Comment 2

[Lars T Hansen [:lth]]

(Disregard comment about atomic loads and stores; I'm juggling too many patches.)

Comment 3

[Lars T Hansen [:lth]]

Attachment: bug1419025-refactor-regalloc-v2.patch

Regalloc refactoring with review comments addressed.  Carrying bbouvier's r+.

Comment 4

[Lars T Hansen [:lth]]

Attachment: bug1419025-scratch-registers.patch

This cleans up the scratch registers further by making the scratch register macros return the typed registers (RegI32 and so on) and not Register or FloatRegister.  It's not a complicated patch but it seemed worth a review.

Comment 5

[Lars T Hansen [:lth]]

Attachment: bug1419025-ifdef-trivialities.patch

Renames some macros used internally in the baseline compiler so that they are less likely to clash with macros defined elsewhere, under unified compilation.  This really is a triviality, I'm just looking for a rubber stamp.

Comment 6

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8930867 [details] [diff] [review]
bug1419025-ifdef-trivialities.patch

Review of attachment 8930867 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 7

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8930866 [details] [diff] [review]
bug1419025-scratch-registers.patch

Review of attachment 8930866 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad749012c057
wasm baseline, refactor registers and register allocation, r=bbouvier
https://hg.mozilla.org/integration/mozilla-inbound/rev/2079792e5c71
wasm baseline, clean up scratch registers further. r=bbouvier
https://hg.mozilla.org/integration/mozilla-inbound/rev/32b00c586da2
wasm baseline, rename some controlling macros. r=bbouvier

Comment 9

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/ad749012c057
https://hg.mozilla.org/mozilla-central/rev/2079792e5c71
https://hg.mozilla.org/mozilla-central/rev/32b00c586da2