Closed Bug 1419055 Opened 3 years ago Closed 3 years ago

Fix FasterMake backend handling of FINAL_TARGET_FILES with wildcards in filename

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

The patch in bug 1407374 adds `LOCALIZED_FILES` entries with wildcards in the name, which are handled by FasterMake the same way as `FINAL_TARGET_FILES`. It turns out that FasterMake's handling of wildcards in filenames is broken.

I guess this isn't a construct we actually use in-tree currently. It's broken with entries like:
```
FINAL_TARGET_FILES += ['*.xyz']
```
Assignee: nobody → ted
Comment on attachment 8930124 [details]
bug 1419055 - Fix FasterMake backend handling of FINAL_TARGET_FILES with wildcards in filename.

https://reviewboard.mozilla.org/r/201292/#review206450

lgtm.  Just a case that wasn't consider, I guess.
Attachment #8930124 - Flags: review+
Do we want to make the emitter smarter about these kinds of cases, so it's more difficult to botch things in the backend?  Surely the FasterMake backend will not be the only one to run into problems like this.
I am not opposed to that, I just don't know what it'd look like precisely. I guess having some sort of `Pattern` class would be useful.
Attachment #8930124 - Flags: review?(core-build-config-reviews)
Comment on attachment 8930124 [details]
bug 1419055 - Fix FasterMake backend handling of FINAL_TARGET_FILES with wildcards in filename.

https://reviewboard.mozilla.org/r/201292/#review206820

::: python/mozbuild/mozbuild/backend/fastermake.py:82
(Diff revision 1)
>  
> +                        if '*' in f.target_basename:
> +                            target = path
> +                        else:
> +                            target = mozpath.join(path, f.target_basename)
> +                        mozpath.join(path, f.target_basename)

Dead code
https://hg.mozilla.org/integration/mozilla-inbound/rev/bca7bf9ad9bf54e1c0e96c2dd8be27f61c50cfbd
bug 1419055 - Fix FasterMake backend handling of FINAL_TARGET_FILES with wildcards in filename. r=nalexander
(In reply to :froydnj (on leave until 2018, ni? or email if necessary) from comment #3)
> Do we want to make the emitter smarter about these kinds of cases, so it's
> more difficult to botch things in the backend?  Surely the FasterMake
> backend will not be the only one to run into problems like this.

I filed bug 1419489 to discuss this.
https://hg.mozilla.org/mozilla-central/rev/bca7bf9ad9bf
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.