1419117 - [cs] Update icons of Firefox desktop search modules

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Seznam.cz
- https://www.seznam.cz/media/img/seznam-icons/favicon.ico
- 32px https://www.seznam.cz/media/img/seznam-icons/favicon-32x32.png
- 16px https://www.seznam.cz/media/img/seznam-icons/favicon-16x16.png

Mapy.cz
- https://mapy.cz/img/favicon/favicon.ico

Other
- seems other icons are up to date, but I should check if they match the en-US original, or different source is used

(Francesco Lodolo [:flod] from bug 1403111)
> Icon for Firefox desktop are .ico, embedding both 16px and 32px

Documentation, how to modify search plugins: https://mozilla-l10n.github.io/documentation/products/searchplugins/setup_searchplugins.html

Comment 1

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: Bug 1419117 - [cs] Update icons of Firefox desktop search modules and use https,

Review commit: https://reviewboard.mozilla.org/r/201546/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201546/

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8930392 [details]
Bug 1419117 - [cs] Update icons of Firefox desktop search modules and use https,

https://reviewboard.mozilla.org/r/201546/#review207274

Great job Michal, everything looks good.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/931eb8bca980
[cs] Update icons of Firefox desktop search modules and use https, r=flod

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/931eb8bca980

Comment 5

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Francesco is this change something we can uplift to beta 58, so it's in the January release? Of course after I can verify in nightly.

CCing Martin Stružský to let him know we have updated the icons.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Michal Stanke (Mozilla.cz) [:MikkCZ][:mstanke] (use needinfo) from comment #5)
> Francesco is this change something we can uplift to beta 58, so it's in the
> January release? Of course after I can verify in nightly.

Yes. Once the bug is fixed and verified, I can take care of the uplift request.

Comment 7

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I have verified in 20171122103138 (Linux) with a clean profile, that the new icons are displayed and all touched search modules work correctly.

Francesco, you can uplift, when you have time.

Comment 8

[Francesco Lodolo [:flod]]

Looks like I need to move this over to Firefox::Search to be able to request uplift.

Comment 9

[Francesco Lodolo [:flod]]

Comment on attachment 8930392 [details]
Bug 1419117 - [cs] Update icons of Firefox desktop search modules and use https,

Approval Request Comment

[Feature/Bug causing the regression]: -

[User impact if declined]: smaller icons, not https search on one searchplugin

[Is this code covered by automated tests?]: no

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]: no

[List of other uplifts needed for the feature/fix]: -

[Is the change risky?]: no

[Why is the change risky/not risky?]: only affect one language (cs), tested, minor changes

[String changes made/needed]: -

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8930392 [details]
Bug 1419117 - [cs] Update icons of Firefox desktop search modules and use https,

This patch updates icons of Firefox desktop search modules and was verified. Beta58+.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/54fa8f9eabe7