1419125 - FxA signup buttons don't work with numeric UTM params

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Craig Cook (:craigcook)]

The Sync feature page shows a "create account" button for Firefox users who are not signed in. However, if you load the page with a 'utm_term' parameter in the URL that has a numeric value (numbers only, no letters) the button doesn't work. Adding any letter or other symbol to the value of utm_term allows the button to function normally.

Steps to reproduce:

1) Go to https://www.mozilla.org/firefox/features/sync/?utm_term=1 in Firefox while signed out.
2) Click the button, nothing happens.
3) Change the parameter value to "1a", or "a1", or "a", or any other non-numeric value and reload the page.
4) The button works as expected.

My best uneducated guess is that some bit of JS somewhere isn't accepting a purely numeric value so is returning false what should be true, and so the button click doesn't execute.

Maybe something to do with the regex at https://github.com/mozilla/bedrock/blob/master/media/js/base/search-params.js#L75 but I don't really know what I'm talking about.

This bug is interfering with snippets and other campaigns.

Comment 1

[Jonathan Petto [:jpetto]]

After a little bit of local testing, it appears that if the object passed to Mozilla.UITour.showFirefoxAccounts contains a key with a numeric value, the call will fail silently.

I have a vague recollection of this being intentional on the UITour end, but I'm not positive.

Since search-params.js also impacts our stub attribution code, I'm going to add a fix just to the utmParamsFxA method of the SearchParams library.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/bedrock/pull/5304

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/7307fff8ed126826754648b9411c6f7cd8d66c72
[fix bug 1419125] Ensure string values in utmParamsFxA.