1419144 - Remove some functions / classes from nsGlobalWindow.cpp

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Nika Layzell [:nika] (ni? for response)]

I'm going to be doing a few passes of cleanup on the code relating to nsGlobalWindow and nsPIDOMWindow. These are probably going to occur as a large number of small patches split across a few bugs whenever I feel like I've accumulated enough of them.

This patch set is focused on removing some of the functions/classes from nsGlobalWindow.cpp.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 1: Move ShouldShowFocusRingIfFocusedByMouse into nsGlobalWindowInner.cpp

MozReview-Commit-ID: 7m5ZJ52bkRs

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 2: Remove unused gThrottledIdlePeriodLength

MozReview-Commit-ID: GGMJC6HuCLa

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 3: Move pref caches into nsGlobalWindowInner where they are used

MozReview-Commit-ID: 1yftLoS3eo2

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 4: Remove RemoveIdleCallback from outer window

MozReview-Commit-ID: KxJgYeOQPyH

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 5: Move CommandDispatcher and ChildCommandDispatcher into nsGlobalWindowOuter.cpp

MozReview-Commit-ID: L41gwz19vBq

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 6: Move IsInterval into nsGlobalWindowInner.cpp

MozReview-Commit-ID: LRhNfAdljYJ

Comment 7

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 7: Move WindowDestroyedEvent into its own file

MozReview-Commit-ID: HZDX84ktgiy

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 8: Move TryGetTabChildGlobalAsEventTarget into nsContentUtils

MozReview-Commit-ID: 8vi1mAzmQUU

Comment 9

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 9: Move CreateNativeGlobalForInner into nsGlobalWindowOuter.cpp

MozReview-Commit-ID: 9KwK7GyXZN3

Comment 10

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 10: Move PushPopupControlState and PopPopupControlState into nsGlobalWindowOuter.cpp

MozReview-Commit-ID: 7AhgZLIvcZ5

Comment 11

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 11: Remove some unused defines

MozReview-Commit-ID: CQI6eWIHzsT

Comment 12

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 12: Move kXULControllersCID into nsGlobalWindowOuter.cpp

MozReview-Commit-ID: 6PNWjgE8vgq

Comment 13

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 13: Move some defines into nsGlobalWindowInner.cpp

MozReview-Commit-ID: C3lK4TORumy

Comment 14

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 14: Move some debug defines to the places where they are used

MozReview-Commit-ID: 5SuLQZqtzJf

Comment 15

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 15: Move gOpenPopupSpamCount to nsGlobalWindowOuter

MozReview-Commit-ID: Kt2moF5nsDg

Comment 16

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 16: Move gDumpFile into nsGlobalWindowInner

MozReview-Commit-ID: 1ATfmoN0oue

Comment 17

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 17: Split gDOMLeakPRLog into Inner/Outer variants

MozReview-Commit-ID: HxjJ43UyecW

Comment 18

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 18: Move AsInner() and AsOuter() off of nsPIDOMWindow<T>

MozReview-Commit-ID: IA29zmacrJ4

Comment 19

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 19: Move IsRootOuterWindow to nsPIDOMWindowOuter

MozReview-Commit-ID: Cgh1Cbb60Zk

Comment 20

[Andrew McCreight [:mccr8]]

You can remove nsGlobalWindowOuter::RiskyUnlink, in case you haven't noticed that.

Comment 21

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 20: Remove nsGlobalWindowOuter::RiskyUnlink

I haven't gone through with a fine toothed comb and removed unused methods, but I figure there's no reason not to remove a method when someone brings it up ^.^.

MozReview-Commit-ID: 3BZIKFc5noK

Comment 22

[Andrew McCreight [:mccr8]]

Comment on attachment 8930250 [details] [diff] [review]
Part 20: Remove nsGlobalWindowOuter::RiskyUnlink

Review of attachment 8930250 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 23

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8930238 [details] [diff] [review]
Part 14: Move some debug defines to the places where they are used

You can kill
+
+#if defined(DEBUG_bryner) || defined(DEBUG_chb)
+#define DEBUG_PAGE_CACHE
+#endif
+

Comment 24

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8930239 [details] [diff] [review]
Part 15: Move gOpenPopupSpamCount to nsGlobalWindowOuter

GetPopupControlState() is not inner only

Comment 25

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 15: Move PopupControlState into nsContentUtils

MozReview-Commit-ID: Kt2moF5nsDg

Comment 26

[Nika Layzell [:nika] (ni? for response)]

Attachment: Part 14: Move some debug defines to the places where they are used

MozReview-Commit-ID: 5SuLQZqtzJf

Comment 27

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8930727 [details] [diff] [review]
Part 15: Move PopupControlState into nsContentUtils

This is a bit confusing to have nsContentUtils::GetPopupControlState and 
nsGlobalWindow*::GetPopupControlState()
Could we just have the first one?

Or at least I would just make nsGlobalWindowInner::GetPopupControlState() to return nsContentUtils::GetPopupControlState() and then there wasn't need to change nsGlobalWindowInner::DialogsAreBeingAbused()
With that, r+

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b4fc8a5f472
Part 1: Move ShouldShowFocusRingIfFocusedByMouse into nsGlobalWindowInner.cpp, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/e863c2b5a8d3
Part 2: Remove unused gThrottledIdlePeriodLength, r=farre
https://hg.mozilla.org/integration/mozilla-inbound/rev/61d666efd282
Part 3: Move pref caches into nsGlobalWindowInner where they are used, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/4435161ad0bc
Part 4: Remove RemoveIdleCallback from outer window, r=farre
https://hg.mozilla.org/integration/mozilla-inbound/rev/98490bf58d1b
Part 5: Move CommandDispatcher and ChildCommandDispatcher into nsGlobalWindowOuter.cpp, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/53bc343fcf1b
Part 6: Move IsInterval into nsGlobalWindowInner.cpp, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d92f87daafa
Part 7: Move WindowDestroyedEvent into its own file, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/752c1ff4c3a4
Part 8: Move TryGetTabChildGlobalAsEventTarget into nsContentUtils, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/f44b0454c43e
Part 9: Move CreateNativeGlobalForInner into nsGlobalWindowOuter.cpp, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f9298059e50
Part 10: Move PushPopupControlState and PopPopupControlState into nsGlobalWindowOuter.cpp, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcb748bda970
Part 11: Remove some unused defines, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/965e9680ca56
Part 12: Move kXULControllersCID into nsGlobalWindowOuter.cpp, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f54c70b06fa
Part 13: Move some defines into nsGlobalWindowInner.cpp, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0be253b85aa
Part 14: Move some debug defines to the places where they are used, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/3db4f6535159
Part 15: Move PopupControlState into nsContentUtils, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba08fd3b33d2
Part 16: Move gDumpFile into nsGlobalWindowInner, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fa06e5b80ba
Part 17: Split gDOMLeakPRLog into Inner/Outer variants, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/9291e7d4b268
Part 18: Move AsInner() and AsOuter() off of nsPIDOMWindow<T>, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b7ee0d7ade8
Part 19: Move IsRootOuterWindow to nsPIDOMWindowOuter, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb55e8d55ff9
Part 20: Remove nsGlobalWindowOuter::RiskyUnlink, r=mccr8

Comment 29

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/7b4fc8a5f472
https://hg.mozilla.org/mozilla-central/rev/e863c2b5a8d3
https://hg.mozilla.org/mozilla-central/rev/61d666efd282
https://hg.mozilla.org/mozilla-central/rev/4435161ad0bc
https://hg.mozilla.org/mozilla-central/rev/98490bf58d1b
https://hg.mozilla.org/mozilla-central/rev/53bc343fcf1b
https://hg.mozilla.org/mozilla-central/rev/5d92f87daafa
https://hg.mozilla.org/mozilla-central/rev/752c1ff4c3a4
https://hg.mozilla.org/mozilla-central/rev/f44b0454c43e
https://hg.mozilla.org/mozilla-central/rev/0f9298059e50
https://hg.mozilla.org/mozilla-central/rev/dcb748bda970
https://hg.mozilla.org/mozilla-central/rev/965e9680ca56
https://hg.mozilla.org/mozilla-central/rev/0f54c70b06fa
https://hg.mozilla.org/mozilla-central/rev/b0be253b85aa
https://hg.mozilla.org/mozilla-central/rev/3db4f6535159
https://hg.mozilla.org/mozilla-central/rev/ba08fd3b33d2
https://hg.mozilla.org/mozilla-central/rev/8fa06e5b80ba
https://hg.mozilla.org/mozilla-central/rev/9291e7d4b268
https://hg.mozilla.org/mozilla-central/rev/4b7ee0d7ade8
https://hg.mozilla.org/mozilla-central/rev/cb55e8d55ff9