1419147 - EM should not call gDetailView._updateView twice for a single onExternalInstall event

Status: NEW

(Toolkit :: Add-ons Manager, enhancement, P5)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This issue is a follow up of Bug 1409697.

As briefly described in Bug 1409697 Comment 5, while investigating Bug 1409697 issue I noticed that currently for every "onExternalInstall" event, gDetailView._updateView is called twice.

The reason seems to be that:

- in gDetailView._updateView, gDetailView is registered as both an "addon events" listener and a "install events" listener (https://searchfox.org/mozilla-central/rev/c633ffa4c4611f202ca11270dcddb7b29edddff8/toolkit/mozapps/extensions/content/extensions.js#3098-3099)

- in gEventManager.delegateInstallEvent, the event received is first sent to the "addon events" listener (using gEventManager.delegateAddonEvent) if any, and then sent to all the "install events" listeners (https://searchfox.org/mozilla-central/rev/c633ffa4c4611f202ca11270dcddb7b29edddff8/toolkit/mozapps/extensions/content/extensions.js#614)

The two _updateview calls happens in a rapid sequence for a single "onExternalInstall" (e.g. related to an addon reload) and so the first call creates an "extension options" browser XUL element which is then immediately removed by the second call.