1419172 - attachment icon in compose window flickers on selection

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[:aceman]

When there are attachments in the <attachmentlist> of the compose window and I click any of them, its icon visibly flickers and the icon gets a 'greyed out' effect to simulate selection, as also the attachment name gets selection highlight.
The flickering (as if icon gets removed and then redrawn) is ugly.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug1419172.patch

This should fix the flickering when selecting7deselecting the attachmentitem. This patch also fixes bug 1419174 and bug 1419177.

On my system I haven't seen the flickering with this patch.

Comment 2

[:aceman]

Comment on attachment 8930628 [details] [diff] [review]
Bug1419172.patch

Review of attachment 8930628 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
So Linux and Windows were missing the width & height attributes?

Why does only Linux need the imageFilters.svg#selected filter? I see it does a slightly lighter shade (grey out) than when the item is focused.
Do other platforms keep the icon greyed out in a different way?

The icon still flickers on first selection in compose window session, probably to load the filter in the svg. But on subsequent selections on any attachments there is no more flicker.

Comment 3

[Richard Marti (:Paenglab)]

The other platforms don't change the icons, the whole line, and not only the text, is selected.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2c76835b3e17
Stop the attachment icon's flickering when selecting/deselecting. r=aceman