Closed
Bug 1419270
Opened 6 years ago
Closed 6 years ago
Make it possible to annotate attr getters and setters separately as needing subject principals
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Whiteboard: Beta approval requested for part 1 only)
Attachments
(2 files, 1 obsolete file)
11.40 KB,
patch
|
qdot
:
review+
gchang
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
26.09 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
We're using NeedsSubjectPrincipal a lot more (e.g. see the GenerateCSS2PropertiesWebIDL.py changes in bug 1415352). Some of the uses are fairly perf-sensitive; we should avoid doing the work if we don't need to. In the inline style case, none of the getters need it, for example.
Flags: needinfo?(bzbarsky)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(bzbarsky)
Summary: Make it possible to annotate attr getters and setters separately as needing caller principals → Make it possible to annotate attr getters and setters separately as needing subject principals
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: 7aBqqWdF6Bn
Attachment #8934589 -
Flags: review?(kyle)
Assignee | ||
Comment 2•6 years ago
|
||
MozReview-Commit-ID: KBwjFh3TMUg
Attachment #8934590 -
Flags: review?(kyle)
Updated•6 years ago
|
Attachment #8934589 -
Flags: review?(kyle) → review+
Updated•6 years ago
|
Attachment #8934590 -
Flags: review?(kyle) → review+
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(bzbarsky)
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/03636aaf6cd7 part 1. Add NeedsSubjectPrincipal to the extended attributes we compute for interface members. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/69b3a04f5947 part 2. Use getter or setter specific NeedsSubjectPrincipal annotations more. r=qdot
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/03636aaf6cd7 https://hg.mozilla.org/mozilla-central/rev/69b3a04f5947
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8934589 [details] [diff] [review] part 1. Add NeedsSubjectPrincipal to the extended attributes we compute for interface members Requesting beta approval for this part, because the patches for bug 1424474 depend on it. Approval Request Comment [Feature/Bug causing the regression]: See bug 1424474. [User impact if declined]: See bug 1424474. [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: [String changes made/needed]:
Attachment #8934589 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 6•6 years ago
|
||
Note: I am only requesting approval for part 1. Part 2 doesn't need backporting.
Whiteboard: Beta approval requested for part 1 only
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8940305 -
Attachment description: Beta 58 backport of part 3 without backported → Beta 58 backport of part 3 for bug 1424474 without this change backported
Attachment #8940305 -
Attachment is obsolete: true
Updated•6 years ago
|
status-firefox58:
--- → affected
Comment 8•6 years ago
|
||
Comment on attachment 8934589 [details] [diff] [review] part 1. Add NeedsSubjectPrincipal to the extended attributes we compute for interface members Take this because the patches for bug 1424474 depend on this one. Beta58+.
Attachment #8934589 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•6 years ago
|
||
bz we had some conflicts with the second patch when we tried to uplift to beta. Could you please take a look?
Flags: needinfo?(bzbarsky)
Comment 10•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/7640a0204f44
Updated•6 years ago
|
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 11•6 years ago
|
||
> bz we had some conflicts with the second patch when we tried to uplift to beta. Could you please take a look? Per comment 6, part 2 did not need uplifting.
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•