1419270 - Make it possible to annotate attr getters and setters separately as needing subject principals

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We're using NeedsSubjectPrincipal a lot more (e.g. see the GenerateCSS2PropertiesWebIDL.py changes in bug 1415352).  Some of the uses are fairly perf-sensitive; we should avoid doing the work if we don't need to.  In the inline style case, none of the getters need it, for example.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Add NeedsSubjectPrincipal to the extended attributes we compute for interface members

MozReview-Commit-ID: 7aBqqWdF6Bn

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Use getter or setter specific NeedsSubjectPrincipal annotations more

MozReview-Commit-ID: KBwjFh3TMUg

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03636aaf6cd7
part 1.  Add NeedsSubjectPrincipal to the extended attributes we compute for interface members.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/69b3a04f5947
part 2.  Use getter or setter specific NeedsSubjectPrincipal annotations more.  r=qdot

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/03636aaf6cd7
https://hg.mozilla.org/mozilla-central/rev/69b3a04f5947

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8934589 [details] [diff] [review]
part 1.  Add NeedsSubjectPrincipal to the extended attributes we compute for interface members

Requesting beta approval for this part, because the patches for bug 1424474 depend on it.

Approval Request Comment
[Feature/Bug causing the regression]:  See bug 1424474.
[User impact if declined]:  See bug 1424474.
[Is this code covered by automated tests?]:  Yes.
[Has the fix been verified in Nightly?]:  Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]:
[String changes made/needed]:

Comment 6

[Boris Zbarsky [:bzbarsky]]

Note: I am only requesting approval for part 1.  Part 2 doesn't need backporting.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Beta 58 backport of part 3 for bug 1424474 without this change backported

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8934589 [details] [diff] [review]
part 1.  Add NeedsSubjectPrincipal to the extended attributes we compute for interface members

Take this because the patches for bug 1424474 depend on this one. Beta58+.

Comment 9

[Cristina Coroiu [:ccoroiu]]

bz we had some conflicts with the second patch when we tried to uplift to beta. Could you please take a look?

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7640a0204f44

Comment 11

[Boris Zbarsky [:bzbarsky]]

> bz we had some conflicts with the second patch when we tried to uplift to beta. Could you please take a look?

Per comment 6, part 2 did not need uplifting.