1419297 - Discarding the browsing context must not change window.customElements

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[John Dai[:jdai]]

Got timeout at custom-elements/custom-element-registry/per-global.html[1][2]

[1] http://w3c-test.org/custom-elements/custom-element-registry/per-global.html
[2] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/testing/web-platform/tests/custom-elements/custom-element-registry/per-global.html

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1419297 - Call document.close, triggering onload and making the test not time out.

This fixes both uses of object-association.js.

Review commit: https://reviewboard.mozilla.org/r/250340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250340/

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1419297 - Don't clear mCustomElements in FreeInnerObjects.

The cycle collecter should make sure the cycle here gets collected and
clearing it causes us to fail a wpt test.

Review commit: https://reviewboard.mozilla.org/r/250342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250342/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8984496 [details]
Bug 1419297 - Call document.close, triggering onload and making the test not time out.

https://reviewboard.mozilla.org/r/250340/#review256642

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8984497 [details]
Bug 1419297 - Don't clear mCustomElements in FreeInnerObjects.

https://reviewboard.mozilla.org/r/250342/#review256644

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8c36d506325532eae86318c393dbeca72f6246f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2762fef0119b
Call document.close, triggering onload and making the test not time out. r=smaug
https://hg.mozilla.org/integration/autoland/rev/d23cd52cc45b
Don't clear mCustomElements in FreeInnerObjects. r=smaug

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11448 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2762fef0119b
https://hg.mozilla.org/mozilla-central/rev/d23cd52cc45b

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged