14193 - [DOGFOOD] use 'chrome:' URLs to save persistence information

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P1)

Description

[Simon Fraser [no longer active]]

If I choose the View->Sidebar menu item, and my sidebar is visible, then the
divider disappears, but the sidebar remains open. Now I have no way of closing it
:(

Comment 1

[Steve Lamm]

I see this on Linux too. For some reason my hiding styles are ignored.

Comment 2

[Simon Fraser [no longer active]]

waterson said this on IRC:

  waterson: okay, we officially leak XULDocument's now.
  waterson: i can tell because persistence stops working
  waterson: so, now, you have to PAY when somebody leaks the XULDoc
  waterson: because the sidebar will NEVER EVER close!!!
            waterson laughs evilly

Comment 3

[Steve Lamm]

Fixed. Hide at will.

Comment 4

[Akkana Peck]

This has come back, at least on Linux.  slamm says (and I believe him) it's
probably due to a webshell leak.

Comment 5

[Akkana Peck]

Steve suggested that I try removing localstore.rdf in my profile directory; I
did that, and now apprunner remembers my sidebar setting.  Kipp, you might want
to try that.

Comment 6

[Steve Lamm]

Kipp, if you would send me your localstore.rdf before you move it aside, that
would help me track down the root of the problem. I forgot to save mine.

Comment 7

[Simon Fraser [no longer active]]

This is the second instance of some local state messing up layout. See also bug
13358 (on local state making the URL bar too wide), which some people still
experience from time to time. There is something nefarious going on here, and I
think someone should look into it.

Comment 8

[Paul MacQuiddy]

verified that view sidebar when the sidebar is open will hide the sidebar
forever. All platforms, 9/24 build.

bug 13901 deals with closing the sidebar with the splitter and having that state
not saved when you re-start.

Comment 9

[Akkana Peck]

It's baaa-ack!  I can hide the sidebar in the 10/1 Linux build via the View
menu, but it comes back on restart.

If I remove localstore.rdf, then run and dismiss the sidebar, this time the
sidebar stays away.  So I guess localstore.rdf is being corrupted somehow?

Comment 10

[Akkana Peck]

Clearing resolution; I'll be attaching my localstore.rdf (I saved the old
nonworking one this time).

Comment 11

[Akkana Peck]

Attachment: localstore.rdf after attempting to dismiss sidebar without first rm'ing localstore.rdf

Comment 12

[Steve Lamm]

akkana uses different build directories and the persistence system is saving
full paths. That means each time akkana creates a new build directory, she loses
all her persisted state. I am unsure if this is what caused kipp or McAfee to
see this problem.

Waterson, can we make the persisted URLs relative to the dist directory?

Comment 13

[Chris Waterson]

Not sure why it's resolving 'chrome:' URLs to fully qualified paths. Yes, seems
like we'd like it to save the 'chrome:' URL, not the expanded file name. You
can assign to me, prolly component == RDF.

Comment 14

[Steve Lamm]

Reassigning to waterson.

Comment 15

[leger]

Not a holder for Dogfood.  There is a workaround.  PDT-

Comment 16

[Chris Waterson]

this is fixed.

Comment 17

[Paul MacQuiddy]

verified with nov5 m11 builds