Closed Bug 1419318 Opened 2 years ago Closed 2 years ago

Fix custom element WPT failures at ShadowRoot.html and disconnected-callbacks.html

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jdai, Assigned: edgar)

References

Details

Attachments

(1 file)

Priority: -- → P2
We need to wait until Shadow DOM v1 implemented.
Priority: P2 → P3
It seems we already support ShadowRoot and what we need to do is just flipping the "dom.webcomponents.enabled" to true.
Assignee: nobody → echen
We support attachShadow after bug 1404842, disconnected-callbacks.html could get passed with flipping the "dom.webcomponents.enabled" to true. I would like to fix this here, too.
Summary: Fix custom element WPT failures at ShadowRoot.html → Fix custom element WPT failures at ShadowRoot.html and disconnected-callbacks.html
Attachment #8936698 - Flags: review?(bugs)
Comment on attachment 8936698 [details]
Bug 1419318 - Flip "dom.webcomponents.enabled" to true when running ShadowRoot.html and disconnected-callbacks.html tests;

https://reviewboard.mozilla.org/r/207428/#review213390
Attachment #8936698 - Flags: review?(bugs) → review+
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0dd41536c894
Flip "dom.webcomponents.enabled" to true when running ShadowRoot.html and disconnected-callbacks.html tests; r=smaug
https://hg.mozilla.org/mozilla-central/rev/0dd41536c894
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.