Closed
Bug 1419320
Opened 7 years ago
Closed 7 years ago
PWA - icon and onboarding image update
Categories
(Firefox for Android Graveyard :: Web Apps (PWAs), defect)
Firefox for Android Graveyard
Web Apps (PWAs)
Tracking
(firefox58 fixed, firefox59 fixed)
RESOLVED
FIXED
Firefox 59
People
(Reporter: Carol, Assigned: cnevinchen)
Details
(Whiteboard: [FNC][SPT59.1][INT])
Attachments
(2 files)
214.03 KB,
image/png
|
Details | |
59 bytes,
text/x-review-board-request
|
maliu
:
review+
jcristau
:
approval-mozilla-beta+
|
Details |
No description provided.
Reporter | ||
Comment 1•7 years ago
|
||
After many rounds of discussion for PWA icon, this is the final icon we want to use. Please help update the assets! thank you!! Assets :https://drive.google.com/open?id=0B-9PIePlQZRlZnpRX3RZRE83Ync
Flags: needinfo?(cnevinchen)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → cnevinchen
Flags: needinfo?(cnevinchen)
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8931249 [details] Bug 1419320 - PWA icon and onboarding image update. https://reviewboard.mozilla.org/r/202388/#review207980
Attachment #8931249 -
Flags: review?(max) → review+
Pushed by nechen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/43ef48d4c5fe PWA icon and onboarding image update. r=maliu
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8931249 [details] Bug 1419320 - PWA icon and onboarding image update. Approval Request Comment [Feature/Bug causing the regression]:PWA onboarding in bug 1393672 [User impact if declined]:User will see wrong icon for pwa [Is this code covered by automated tests?]:no [Has the fix been verified in Nightly?]:no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]:mp [Is the change risky?]:no [Why is the change risky/not risky?]: just changing icon resouce [String changes made/needed]:no
Attachment #8931249 -
Flags: approval-mozilla-beta?
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/43ef48d4c5fe
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Comment 7•7 years ago
|
||
Comment on attachment 8931249 [details] Bug 1419320 - PWA icon and onboarding image update. Update the PWA icon. Beta58+.
Attachment #8931249 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•7 years ago
|
status-firefox58:
--- → affected
Assignee | ||
Comment 8•7 years ago
|
||
Sorry some images needs to be updated again.
Updated•7 years ago
|
Attachment #8931249 -
Flags: approval-mozilla-beta+ → approval-mozilla-beta-
Updated•7 years ago
|
Whiteboard: [FNC][SPT59.1][INT]
Comment 9•7 years ago
|
||
What's the status here? Are more changes planned for beta58?
Flags: needinfo?(cnevinchen)
Assignee | ||
Comment 10•7 years ago
|
||
We want to fix the bug here https://bugzilla.mozilla.org/show_bug.cgi?id=1421916 May I know what should I do here?
Flags: needinfo?(cnevinchen) → needinfo?(jcristau)
Assignee | ||
Comment 11•7 years ago
|
||
Hi Julien I'll do the uplift in bug 1421916. thanks!
Flags: needinfo?(jcristau)
Assignee | ||
Updated•7 years ago
|
Comment 12•7 years ago
|
||
Comment on attachment 8931249 [details] Bug 1419320 - PWA icon and onboarding image update. beta58+, dependency of bug 1421916
Attachment #8931249 -
Flags: approval-mozilla-beta- → approval-mozilla-beta+
Comment 13•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/58f61575432c
Comment 14•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/b05a3895f0d5
Updated•7 years ago
|
Comment 15•7 years ago
|
||
The previous landing got backed out for landing in the wrong order: https://hg.mozilla.org/releases/mozilla-beta/rev/1278aa8db7ba21bfc527c63c9ba6c9c80f674dba
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•