PWA - icon and onboarding image update

RESOLVED FIXED in Firefox 58

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Carol, Assigned: cnevinchen)

Tracking

unspecified
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox58 fixed, firefox59 fixed)

Details

(Whiteboard: [FNC][SPT59.1][INT])

Attachments

(2 attachments)

Reporter

Description

2 years ago
Posted image PWA_1121_update.png
No description provided.
Reporter

Comment 1

2 years ago
After many rounds of discussion for PWA icon, this is the final icon we want to use. 
Please help update the assets! thank you!!
Assets :https://drive.google.com/open?id=0B-9PIePlQZRlZnpRX3RZRE83Ync
Flags: needinfo?(cnevinchen)
Comment hidden (mozreview-request)
Assignee: nobody → cnevinchen
Flags: needinfo?(cnevinchen)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8931249 [details]
Bug 1419320 - PWA icon and onboarding image update.

https://reviewboard.mozilla.org/r/202388/#review207980
Attachment #8931249 - Flags: review?(max) → review+

Comment 4

2 years ago
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43ef48d4c5fe
PWA icon and onboarding image update. r=maliu
Comment on attachment 8931249 [details]
Bug 1419320 - PWA icon and onboarding image update.

Approval Request Comment
[Feature/Bug causing the regression]:PWA onboarding in bug 1393672
[User impact if declined]:User will see wrong icon for pwa
[Is this code covered by automated tests?]:no
[Has the fix been verified in Nightly?]:no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:mp
[Is the change risky?]:no
[Why is the change risky/not risky?]: just changing icon resouce
[String changes made/needed]:no
Attachment #8931249 - Flags: approval-mozilla-beta?

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/43ef48d4c5fe
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Comment on attachment 8931249 [details]
Bug 1419320 - PWA icon and onboarding image update.

Update the PWA icon. Beta58+.
Attachment #8931249 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Sorry some images needs to be updated again.
Attachment #8931249 - Flags: approval-mozilla-beta+ → approval-mozilla-beta-

Updated

2 years ago
Whiteboard: [FNC][SPT59.1][INT]
What's the status here?  Are more changes planned for beta58?
Flags: needinfo?(cnevinchen)
We want to fix the bug here https://bugzilla.mozilla.org/show_bug.cgi?id=1421916
May I know what should I do here?
Flags: needinfo?(cnevinchen) → needinfo?(jcristau)
Hi Julien
I'll do the uplift in bug 1421916. thanks!
Flags: needinfo?(jcristau)
Comment on attachment 8931249 [details]
Bug 1419320 - PWA icon and onboarding image update.

beta58+, dependency of bug 1421916
Attachment #8931249 - Flags: approval-mozilla-beta- → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.