Closed Bug 1419321 Opened 2 years ago Closed 2 years ago

Linking on Solaris is missing -L${DIST}/bin

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: petr.sumbera, Assigned: petr.sumbera)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171112125346

Steps to reproduce:

179:40.02 Executing: /usr/bin/g++ -std=gnu++14 -o plugin-container -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -fno-sized-deallocation -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -O -fno-omit-frame-pointer @/scratch/firefox/obj-x86_64-pc-solaris2.11/ipc/app/tmp015bl1.list -lpthread -Wl,-z,text -rdynamic ../../config/external/nspr/pr/libnspr4.so ../../config/external/nspr/libc/libplc4.so ../../config/external/nspr/ds/libplds4.so ../../toolkit/library/libxul.so -lsocket
179:40.02 /scratch/firefox/obj-x86_64-pc-solaris2.11/ipc/app/tmp015bl1.list:
179:40.04     MozillaRuntimeMain.o
179:40.04     ../../mozglue/build/SSE.o
179:40.04     ../../mozglue/build/dummy.o
179:40.04     ../../memory/build/Unified_cpp_memory_build0.o
179:40.04     ../../memory/mozalloc/mozalloc_abort.o
179:40.04     ../../memory/mozalloc/Unified_cpp_memory_mozalloc0.o
179:40.04     ../../mozglue/misc/AutoProfilerLabel.o
179:40.04     ../../mozglue/misc/ConditionVariable_posix.o
179:40.04     ../../mozglue/misc/Mutex_posix.o
179:40.04     ../../mozglue/misc/Printf.o
179:40.04     ../../mozglue/misc/StackWalk.o
179:40.04     ../../mozglue/misc/TimeStamp.o
179:40.04     ../../mozglue/misc/TimeStamp_posix.o
179:40.04     ../../mfbt/lz4.o
179:40.04     ../../mfbt/Compression.o
179:40.04     ../../mfbt/Decimal.o
179:40.05     ../../mfbt/Unified_cpp_mfbt0.o
179:40.10     ../../mfbt/Unified_cpp_mfbt1.o
179:40.10     ../../memory/fallible/fallible.o
179:40.10
179:40.10 ld: warning: file liblgpllibs.so: required by ../../toolkit/library/libxul.so, not found
179:40.10 ld: warning: file libnss3.so: required by ../../toolkit/library/libxul.so, not found
179:40.10 ld: warning: file libnssutil3.so: required by ../../toolkit/library/libxul.so, not found
179:40.10 ld: warning: file libsmime3.so: required by ../../toolkit/library/libxul.so, not found
179:40.10 ld: warning: file libmozsqlite3.so: required by ../../toolkit/library/libxul.so, not found
179:40.10 ld: warning: file libssl3.so: required by ../../toolkit/library/libxul.so, not found
179:40.10 ld: warning: file libmozgtk.so: required by ../../toolkit/library/libxul.so, not found
179:40.10 Undefined                     first referenced
179:40.10  symbol                           in file
179:40.11 PK11_HasAttributeSet                ../../toolkit/library/libxul.so
179:40.11 gtk_fixed_new                       ../../toolkit/library/libxul.so
179:40.11 SSL_GetClientAuthDataHook           ../../toolkit/library/libxul.so
..
Attached patch Bug1419321.patchSplinter Review
Attachment #8930403 - Flags: review?(mh+mozilla)
Status: UNCONFIRMED → NEW
Component: Untriaged → Build Config
Ever confirmed: true
Product: Firefox → Core
Attachment #8930403 - Flags: review?(mh+mozilla) → review?(cmanchester)
Attachment #8930403 - Flags: review?(cmanchester) → review+
Keywords: checkin-needed
Assignee: nobody → petr.sumbera
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e00d3b7df15
Linking on Solaris is missing -L${DIST}/bin. r=chmanchester
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6e00d3b7df15
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.