1419330 - Make GetXBLBinding not an unconditional virtual call.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Bug 1418560 adds a GetXBLBinding call in the fast path for GetFlattenedTreeParent, making it... not that fast :)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1419330: Make GetXBLBinding not an unconditional virtual call.

Review commit: https://reviewboard.mozilla.org/r/201570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201570/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8930405 [details]
Bug 1419330: Make GetXBLBinding not an unconditional virtual call.

https://reviewboard.mozilla.org/r/201570/#review206860

::: dom/base/nsIContent.h:691
(Diff revision 1)
>    /**
>     * Gets the current XBL binding that is bound to this element.
>     *
>     * @return the current binding.
>     */
> -  virtual nsXBLBinding *GetXBLBinding() const = 0;
> +  nsXBLBinding* GetXBLBinding() const {

{ goes to its own line.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8930405 [details]
Bug 1419330: Make GetXBLBinding not an unconditional virtual call.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201570/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06f11b61118d
Make GetXBLBinding not an unconditional virtual call. r=smaug

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/06f11b61118d