Closed Bug 1419330 Opened 2 years ago Closed 2 years ago

Make GetXBLBinding not an unconditional virtual call.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1418560 adds a GetXBLBinding call in the fast path for GetFlattenedTreeParent, making it... not that fast :)
Comment on attachment 8930405 [details]
Bug 1419330: Make GetXBLBinding not an unconditional virtual call.

https://reviewboard.mozilla.org/r/201570/#review206860

::: dom/base/nsIContent.h:691
(Diff revision 1)
>    /**
>     * Gets the current XBL binding that is bound to this element.
>     *
>     * @return the current binding.
>     */
> -  virtual nsXBLBinding *GetXBLBinding() const = 0;
> +  nsXBLBinding* GetXBLBinding() const {

{ goes to its own line.
Attachment #8930405 - Flags: review?(bugs) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/06f11b61118d
Make GetXBLBinding not an unconditional virtual call. r=smaug
https://hg.mozilla.org/mozilla-central/rev/06f11b61118d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.