1419337 - Remove aStyleContext parameter from nsFrameConstructorState::AddChild

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Tommy Kuo (away forever...)]

I found we don't use aStyleContext inside nsFrameConstructorState::AddChild(). Maybe it came from the legacy code, so I think we should remove it.

Comment 1

[Tommy Kuo (away forever...)]

Attachment: Bug 1419337 - Remove aStyleContext parameter from nsFrameConstructorState::AddChild().

We don't use aStyleContext inside nsFrameConstructorState::AddChild(), so I
think we should remove it.

Review commit: https://reviewboard.mozilla.org/r/201580/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201580/

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8930410 [details]
Bug 1419337 - Remove aStyleContext parameter from nsFrameConstructorState::AddChild().

https://reviewboard.mozilla.org/r/201580/#review206826

::: layout/base/nsCSSFrameConstructor.cpp:927
(Diff revision 1)
>     * right.  Also, this MUST be called on frames after they have been
>     * initialized.
>     * @param aNewFrame the frame to add
>     * @param aFrameItems the list to add in-flow frames to
>     * @param aContent the content pointer for aNewFrame
>     * @param aStyleContext the style context resolved for aContent

Remove this comment, please.

Comment 3

[Tommy Kuo (away forever...)]

Comment on attachment 8930410 [details]
Bug 1419337 - Remove aStyleContext parameter from nsFrameConstructorState::AddChild().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201580/diff/1-2/

Comment 4

[Tommy Kuo (away forever...)]

Comment on attachment 8930410 [details]
Bug 1419337 - Remove aStyleContext parameter from nsFrameConstructorState::AddChild().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201580/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d56832437a0b
Remove aStyleContext parameter from nsFrameConstructorState::AddChild(). r=TYLin

Comment 6

[Tommy Kuo (away forever...)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=501bdf9652d3ae261598317a5c3ff371c1b5d465

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/d56832437a0b