Closed Bug 1419337 Opened 2 years ago Closed 2 years ago

Remove aStyleContext parameter from nsFrameConstructorState::AddChild

Categories

(Core :: Layout, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: kuoe0.tw, Assigned: kuoe0.tw)

Details

Attachments

(1 file)

I found we don't use aStyleContext inside nsFrameConstructorState::AddChild(). Maybe it came from the legacy code, so I think we should remove it.
Attachment #8930410 - Flags: review?(tlin)
Comment on attachment 8930410 [details]
Bug 1419337 - Remove aStyleContext parameter from nsFrameConstructorState::AddChild().

https://reviewboard.mozilla.org/r/201580/#review206826

::: layout/base/nsCSSFrameConstructor.cpp:927
(Diff revision 1)
>     * right.  Also, this MUST be called on frames after they have been
>     * initialized.
>     * @param aNewFrame the frame to add
>     * @param aFrameItems the list to add in-flow frames to
>     * @param aContent the content pointer for aNewFrame
>     * @param aStyleContext the style context resolved for aContent

Remove this comment, please.
Attachment #8930410 - Flags: review?(tlin) → review+
Pushed by tokuo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d56832437a0b
Remove aStyleContext parameter from nsFrameConstructorState::AddChild(). r=TYLin
https://hg.mozilla.org/mozilla-central/rev/d56832437a0b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.