Closed Bug 1419359 Opened 2 years ago Closed 2 years ago

Some followups after bug 1415853

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(2 files)

Just some minor things I noticed.
LazyLinkTopActivation currently uses TlsContext and a frame iterator. We can just pass the cx and LazyLinkExitFrameLayout* to it.

This is just like what the interpreter stub is already doing.
Attachment #8930429 - Flags: review?(bbouvier)
This is similar to what we used to do here for scripts without JIT code (before bug 1415853):

https://searchfox.org/mozilla-central/rev/c633ffa4c4611f202ca11270dcddb7b29edddff8/js/src/jit/BaselineIC.cpp#2209-2214

Lazy scripts are just like that: we can optimize them next time after delazifying.
Attachment #8930434 - Flags: review?(bbouvier)
Comment on attachment 8930429 [details] [diff] [review]
Part 1 - Optimize LazyLinkTopActivation

Review of attachment 8930429 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet!
Attachment #8930429 - Flags: review?(bbouvier) → review+
Comment on attachment 8930434 [details] [diff] [review]
Part 2 - Handle lazy scripts better in TryAttachCallStub

Review of attachment 8930434 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #8930434 - Flags: review?(bbouvier) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d02bed4fe6ab
part 1 - Get rid of frame iterator in LazyLinkTopActivation. r=bbouvier
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2725b07d0a5
part 2 - Handle lazy functions better in TryAttachCallStub. r=bbouvier
https://hg.mozilla.org/mozilla-central/rev/d02bed4fe6ab
https://hg.mozilla.org/mozilla-central/rev/e2725b07d0a5
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.