Closed
Bug 1419359
Opened 6 years ago
Closed 6 years ago
Some followups after bug 1415853
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(2 files)
3.48 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
1.57 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
Just some minor things I noticed.
Assignee | ||
Comment 1•6 years ago
|
||
LazyLinkTopActivation currently uses TlsContext and a frame iterator. We can just pass the cx and LazyLinkExitFrameLayout* to it. This is just like what the interpreter stub is already doing.
Attachment #8930429 -
Flags: review?(bbouvier)
Assignee | ||
Comment 2•6 years ago
|
||
This is similar to what we used to do here for scripts without JIT code (before bug 1415853): https://searchfox.org/mozilla-central/rev/c633ffa4c4611f202ca11270dcddb7b29edddff8/js/src/jit/BaselineIC.cpp#2209-2214 Lazy scripts are just like that: we can optimize them next time after delazifying.
Attachment #8930434 -
Flags: review?(bbouvier)
Comment 3•6 years ago
|
||
Comment on attachment 8930429 [details] [diff] [review] Part 1 - Optimize LazyLinkTopActivation Review of attachment 8930429 [details] [diff] [review]: ----------------------------------------------------------------- Sweet!
Attachment #8930429 -
Flags: review?(bbouvier) → review+
Comment 4•6 years ago
|
||
Comment on attachment 8930434 [details] [diff] [review] Part 2 - Handle lazy scripts better in TryAttachCallStub Review of attachment 8930434 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks!
Attachment #8930434 -
Flags: review?(bbouvier) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d02bed4fe6ab part 1 - Get rid of frame iterator in LazyLinkTopActivation. r=bbouvier https://hg.mozilla.org/integration/mozilla-inbound/rev/e2725b07d0a5 part 2 - Handle lazy functions better in TryAttachCallStub. r=bbouvier
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d02bed4fe6ab https://hg.mozilla.org/mozilla-central/rev/e2725b07d0a5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•