141936 - Crash in NSS searching for certificates with zero length nicknames

Status: VERIFIED FIXED

(NSS :: Libraries, defect, P2)

Description

[Kai Engert [:KaiE:]]

Please see http://bugzilla.mozilla.org/show_bug.cgi?id=139329 comments #17 and
#18 for the full description of the problem.

Comment 1

[Wan-Teh Chang]

Assigned the bug to Julien.

Kai, I am assigning a P2 priority to this bug because the
PSM bug 139329 has been fixed.  Are you using a workaround?

It's also not clear if the summary of this bug is correct.
In http://bugzilla.mozilla.org/show_bug.cgi?id=139329#c17,
the crash is caused by a NULL nickname, whereas the summary
of this bug says "zero length email address".  Which one is
correct?

Comment 2

[Ian McGreer]

Attachment: fix crash with zero-length nickname

The fix looked obvious to me, so here it is.  Julien, you can have the honors
of reviewing it :)

Comment 3

[Ian McGreer]

checked in.  Marking fixed, since I believe this eliminates the crash described
in the other bug.  Can't verify, though, since PSM already works around the problem.

Comment 4

[Wan-Teh Chang]

Ian,

A question for you: in this particular function
(pkistore.c:match_nickname), do we consider NULL and ""
as equal, or are we only interested in nicknames that
are not empty?

Comment 5

[Ian McGreer]

We are only interested in certificates that actually have a nickname set that is
non-zero.  PKCS#11 does not include the terminating NULL character, so one could
not search for a NULL string anyway.

Comment 6

[Kai Engert [:KaiE:]]

Wan-Teh, my bad, it's indeed about zero length nicknames. Changing summary.

Comment 7

[Wan-Teh Chang]

Kai,

Actually, it's about NULL nicknames, as opposed to zero length
nicknames (which means "" to me), correct?

Comment 8

[Kai Engert [:KaiE:]]

Wan-Teh, if you look at http://bugzilla.mozilla.org/show_bug.cgi?id=139329#c17
you can see that PSM does not pass a NULL string - it passes a zero length
string "".

But somehow, when the NSS code arrives in match_nickname, it arrives there with
a NULL nickname argument.

The conversion from "" to NULL must happen somewhere inside NSS' code.

Comment 9

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch. Pls check this in
asap. thanks! 

Comment 10

[Charles Rosendahl]

.