Closed
Bug 1419487
Opened 6 years ago
Closed 6 years ago
Remaing DevTools components to ES6 Classes, prop-types and react-dom-factories
Categories
(DevTools :: Inspector, enhancement, P2)
DevTools
Inspector
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: miker, Assigned: miker)
Details
Attachments
(1 file)
There are a number of reasons for this: 1. We need to have the modules available for code from devtools-core, which uses them. 2. It begins the process of getting rid of React deprecation warnings. 3. It prepares us to upgrade to React 16. Versioning info from devtools-core github repo: "prop-types": "^15.6.0" "react-dom-factories": "^1.0.2"
Assignee | ||
Comment 1•6 years ago
|
||
## Using React.createClass ./client/inspector/test/browser_inspector_addSidebarTab.js:25: let tabPanel = React.createFactory(React.createClass({ ./client/inspector/test/browser_inspector_addSidebarTab.js:43: tabPanel = React.createFactory(React.createClass({ ./client/shared/components/Tree.js:57: * const MyTree = createClass({ ./client/debugger/new/debugger.js reps ## Using React.DOM ./client/animationinspector/components/animation-timeline.js:99: startPanel: React.DOM.div({ ./client/animationinspector/components/animation-timeline.js:102: endPanel: React.DOM.div({ client/inspector/events/components/EventsApp.js:8 ./client/inspector/changes/components/ChangesApp.js:8: DOM: dom, ./client/inspector/animation/components/AnimationTimelineTickList.js:7:const { createFactory, DOM: dom, PropTypes, PureComponent } ./client/inspector/animation/components/AnimationTimelineTickItem.js:7:const { DOM: dom, PropTypes, PureComponent } = ./client/inspector/animation/components/AnimationListContainer.js:7:const { createFactory, DOM: dom, PropTypes, PureComponent } = ./client/inspector/animation/components/AnimationListHeader.js:7:const { createFactory, DOM: dom, PropTypes, PureComponent } = ./client/debugger/new/debugger.js reps
Assignee | ||
Updated•6 years ago
|
Has STR: --- → yes
OS: Unspecified → All
Hardware: Unspecified → All
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8931013 [details] Bug 1419487 - Remaing DevTools components to ES6 Classes, prop-types and react-dom-factories https://reviewboard.mozilla.org/r/202102/#review207480
Attachment #8931013 -
Flags: review?(gl) → review+
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/11885fe0fa5e Remaing DevTools components to ES6 Classes, prop-types and react-dom-factories r=gl
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/11885fe0fa5e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•