1419527 - Make spinner.js use new scrollend event instead of a timer to detect when scroll has finished.

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, enhancement, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

spinner.js is used by our date/time selector widget, and we use a timeout scheme to determine when smooth scrolling has finished - example:

https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/toolkit/content/widgets/spinner.js#158-165

In bug 1172171, I added a chrome-only scrollend event. We should try using that instead.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey scottwu, interested in seeing if we can use scrollend here instead of the timer?

Comment 2

[Scott Wu [:scottwu]]

Attachment: Bug 1419527 - Use scrollend event to detect when spinner stops.

Review commit: https://reviewboard.mozilla.org/r/202422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202422/

Comment 3

[Scott Wu [:scottwu]]

Thanks for making that event available!

I gave it a try and it works fine with smooth scrolling, but the `scrollend` event doesn't seem to always fire last when I scroll with my trackpad on a mac? I frequently get another `scroll` event after `scrollend`. Is this an expected behaviour?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Thanks scottwu - you helped me find a bug in my scrollend event mechanism!

Filed bug 1421351 for that. Once that's fixed, I believe this bug can be addressed.

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8931275 [details]
Bug 1419527 - Use scrollend event to detect when spinner stops.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202422/diff/1-2/

Comment 6

[Scott Wu [:scottwu]]

Yes the issue has gone away, thanks!

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8931275 [details]
Bug 1419527 - Use scrollend event to detect when spinner stops.

https://reviewboard.mozilla.org/r/202422/#review209438

Great, thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a5b6591d679
Use scrollend event to detect when spinner stops. r=mconley

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7a5b6591d679