Closed Bug 1419534 Opened 7 years ago Closed 6 years ago

Write some talos pageloader unittests

Categories

(Testing :: Talos, enhancement)

Product:
Testing
Component:
Talos
Version:
Version 3
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: rwood, Assigned: igoldan)

References

Details

Add them to the existing talos python unit test suite (./mach python-test) at [1]

[1] https://searchfox.org/mozilla-central/source/testing/talos/talos/unittests/test_pageloader
Whiteboard: [PI:December]
:igoldan, is this something you'd be interested in, to help learn the pageloader code better?
Flags: needinfo?(igoldan)
Whiteboard: [PI:December] → [PI:January]
Yes, I agree. This sounds good!
Flags: needinfo?(igoldan)
Assignee: rwood → igoldan
:igoldan, how is this coming along (is this something you can complete in February)? I'm going to add it to the Feb priorities list if that's alright
Flags: needinfo?(igoldan)
Whiteboard: [PI:January] → [PI:February]
I would like to put this off, if not wontfix; we want to move to a newer model for benchmarks and pageload tests that can work multi browser (i.e. web extension).  I don't believe we will get rid of pageloader anytime soon- I see very few modifications on it though.
Flags: needinfo?(igoldan)
Whiteboard: [PI:February]
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #4)
> I would like to put this off, if not wontfix; we want to move to a newer
> model for benchmarks and pageload tests that can work multi browser (i.e.
> web extension).  I don't believe we will get rid of pageloader anytime soon-
> I see very few modifications on it though.

Wontfix them.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.