Closed Bug 1419585 Opened 5 years ago Closed 5 years ago

Make warnings into errors during test runs and fix existing warnings

Categories

(Socorro :: General, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: osmose, Assigned: willkg)

Details

Attachments

(2 files)

The following warning is captured and logged during the test run:

socorro/unittest/cron/jobs/test_bugzilla.py::IntegrationTestBugzilla::test_basic_run_job
  /usr/local/lib/python2.7/site-packages/configman/config_manager.py:862: UserWarning: Invalid options: logger
    'Invalid options: %s' % ', '.join(sorted(unmatched_keys))

-- Docs: http://doc.pytest.org/en/latest/warnings.html

However, because warnings do not fail the test run, the tests pass automation and the warning goes unnoticed unless you run the tests locally.

We should probably configure warnings to be errors to push ourselves to act upon them. And, since the commit that changes that will fail automation if it works correctly, we'll also need to fix the warning above to get things passing. :D
I think this is a P2 - we should do it soon, but it's not a fire or anything.
Priority: -- → P2
Grabbing this one. Pretty sure it's a configuration change.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
This PR fixed the test_bugzilla logger warning: https://github.com/mozilla-services/socorro/pull/4256
Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/fd57c440bc781dc5fafc080afcfbdda91315e521
bug 1419585 - all warnings are errors for socorro tests

This fixes the socorro tests such that all warnings are now considered
errors. This also fixes the handful of warnings that were getting kicked
up.

This doesn't fix the webapp tests--we'll do that in another PR.

https://github.com/mozilla-services/socorro/commit/cbfc96fee5ca6bfbe5c4da1fa075d719f776c858
Merge pull request #4260 from willkg/1419585-warnings

bug 1419585 - all warnings are errors for socorro tests
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.