Closed
Bug 1419586
Opened 7 years ago
Closed 7 years ago
Allow painted layers with ancestor mask layers to use OMTP
Categories
(Core :: Graphics: Layers, enhancement)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: rhunt, Assigned: rhunt)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
From talking with David, we don't think we need to restrict OMTP to layers without mask layers. [1] The mask layer rendering is just sending over transaction information [3], and the actual rasterization takes place in FrameLayerBuilder [2] which should happen after we have FlushedAsyncPaints() but before we have queued any new ones, so there should be no contention with Direct2D. I'm going to do a try run to verify there are no obvious issues. [1] https://searchfox.org/mozilla-central/rev/797c93d81fe446f78babf20894f0729f15f71ee6/gfx/layers/client/ClientPaintedLayer.cpp#71 [2] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/layout/painting/FrameLayerBuilder.cpp#3930 [3] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/gfx/layers/client/ClientImageLayer.cpp#134
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2338ade8d38b8cbc1c145cb19efb46d4857ee18
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8930951 [details] Allow painted layers with ancestor mask layers to use OMTP (bug 1419586, ) https://reviewboard.mozilla.org/r/202036/#review208382
Attachment #8930951 -
Flags: review?(dvander) → review+
Blocks: 1420825
Pushed by rhunt@eqrion.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/444fef22c201 Allow painted layers with ancestor mask layers to use OMTP (bug 1419586, r=dvander)
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/444fef22c201
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/444fef22c201
You need to log in
before you can comment on or make changes to this bug.
Description
•