Closed Bug 1419586 Opened 2 years ago Closed 2 years ago

Allow painted layers with ancestor mask layers to use OMTP

Categories

(Core :: Graphics: Layers, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

From talking with David, we don't think we need to restrict OMTP to layers without mask layers. [1]

The mask layer rendering is just sending over transaction information [3], and the actual rasterization takes place in FrameLayerBuilder [2] which should happen after we have FlushedAsyncPaints() but before we have queued any new ones, so there should be no contention with Direct2D.

I'm going to do a try run to verify there are no obvious issues.

[1] https://searchfox.org/mozilla-central/rev/797c93d81fe446f78babf20894f0729f15f71ee6/gfx/layers/client/ClientPaintedLayer.cpp#71
[2] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/layout/painting/FrameLayerBuilder.cpp#3930
[3] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/gfx/layers/client/ClientImageLayer.cpp#134
Comment on attachment 8930951 [details]
Allow painted layers with ancestor mask layers to use OMTP (bug 1419586, )

https://reviewboard.mozilla.org/r/202036/#review208382
Attachment #8930951 - Flags: review?(dvander) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/444fef22c201
Allow painted layers with ancestor mask layers to use OMTP (bug 1419586, r=dvander)
https://hg.mozilla.org/mozilla-central/rev/444fef22c201
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.