1419586 - Allow painted layers with ancestor mask layers to use OMTP

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

From talking with David, we don't think we need to restrict OMTP to layers without mask layers. [1]

The mask layer rendering is just sending over transaction information [3], and the actual rasterization takes place in FrameLayerBuilder [2] which should happen after we have FlushedAsyncPaints() but before we have queued any new ones, so there should be no contention with Direct2D.

I'm going to do a try run to verify there are no obvious issues.

[1] https://searchfox.org/mozilla-central/rev/797c93d81fe446f78babf20894f0729f15f71ee6/gfx/layers/client/ClientPaintedLayer.cpp#71
[2] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/layout/painting/FrameLayerBuilder.cpp#3930
[3] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/gfx/layers/client/ClientImageLayer.cpp#134

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2338ade8d38b8cbc1c145cb19efb46d4857ee18

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Allow painted layers with ancestor mask layers to use OMTP (bug 1419586, )

Review commit: https://reviewboard.mozilla.org/r/202036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202036/

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8930951 [details]
Allow painted layers with ancestor mask layers to use OMTP (bug 1419586, )

https://reviewboard.mozilla.org/r/202036/#review208382

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/444fef22c201
Allow painted layers with ancestor mask layers to use OMTP (bug 1419586, r=dvander)

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/444fef22c201

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/444fef22c201