Closed Bug 1419615 Opened 7 years ago Closed 7 years ago

Ugly synthetic italic on cairo

Categories

(Core :: Graphics: Text, defect)

Product:
Core
Component:
Graphics: Text
Version:
59 Branch
Platform:
x86
Windows 10
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- verified

People

(Reporter: ananuti, Assigned: jfkthame)

References

Details

(Keywords: regression)

Attachments

(4 files)

synthetic-italics-tests.html
1.53 KB, text/html
Details
good.png
16.40 KB, image/png
Details
bad.png
13.15 KB, image/png
Details
Remove old synthetic-italic support from the GDI font code, so we don't double-slant text now that we have generic support in gfxFont
13.87 KB, patch
lsalzman
: review+
Details | Diff | Splinter Review 
The text looks really bad.
Attached image good.png — 

    
    

    
  

      
      
      
      

        Attached image
          
        bad.png
        — 
      

    


  
first bad since bug 1416795.

    
    

    
  
Ugh, that looks like it may be getting "doubly slanted" or something. Which platform is this on?

    
  
Flags: needinfo?(ananuti)

    
    

    
  
I'm on Windows 10.
Flags: needinfo?(ananuti)
OS: Unspecified → Windows 10
Hardware: Unspecified → x86

    
    

    
  
Yes, I can reproduce this on Windows by disabling hardware acceleration. The GDI font backend needs some more of the old synthetic-italic support removed, so we don't end up applying the slant at two levels (cumulatively) here.
Assignee: nobody → jfkthame
Keywords: regression

    
    

    
  


  
This is perhaps the best kind of patch.... all code removal. :)

        Attachment #8931000 -
        Flags: review?(jmuizelaar)

    
    

    
  
Ekanan Ketunuti: if you'd like to test a build with this patch, there's a try run at https://treeherder.mozilla.org/#/jobs?repo=try&revision=1dd4dcf1efbb7c47ea028921129730d9b17ea65b.

    
    

    
  
(In reply to Jonathan Kew (:jfkthame) from comment #7)
> Ekanan Ketunuti: if you'd like to test a build with this patch, there's a
> try run at
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=1dd4dcf1efbb7c47ea028921129730d9b17ea65b.

Thanks, it fixes the problem.

    
  

        Attachment #8931000 -
        Flags: review?(jmuizelaar) → review?(lsalzman)

        Attachment #8931000 -
        Flags: review?(lsalzman) → review+

    
    

    
  
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ba4e83dbd7d
Remove old synthetic-italic support from the GDI font code, so we don't double-slant text now that we have generic support in gfxFont. r=lsalzman

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/2ba4e83dbd7d
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox59:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59

    
    

    
  
Verified on nightly 20171124100500.
Status: RESOLVED → VERIFIED

          status-firefox59:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: