Closed Bug 1419623 Opened 7 years ago Closed 5 years ago

Detect disallowed content. usage from helper functions for no-cpows-in-tests

Categories

(Developer Infrastructure :: Lint and Formatting, enhancement)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: Mardak, Unassigned)

References

Details

Split from bug 1417017 comment 9. Not sure if we want to handle (can we?) head.js defined helper functions, but at least for functions defined in the same test file, we should be able to evaluate whether functions or callbacks passed around should be allowed to access content.*.

For example, a `function foo() { content.blah; }` is allowed only if it gets used as ContentTask.spawn's task / 3rd parameter. This could happen directly via ContentTask.spawn(…, foo) or indirectly where foo is passed as an argument to some helper that calls spawn.
billm is removing a bunch of CPOWs in bug 1412456, so let's hold off on adjusting the rule leading to unnecessary rebase conflicts.
See Also: → 1412456
Product: Testing → Firefox Build System

We no longer have the no-cpows-in-tests rule so I think this is no longer required.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.