1419666 - MemoryBlockCacheTelemetry::NotifyCombinedSizeGrown() should assert the main thread only for the first call

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P5)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://searchfox.org/mozilla-central/rev/797c93d81fe446f78babf20894f0729f15f71ee6/dom/media/MemoryBlockCache.cpp#72-74

For the 2nd call might happen off the main thread.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1419666 - MemoryBlockCacheTelemetry::NotifyCombinedSizeGrown() should assert the main thread only for the first call.

For the 2nd call might happen off the main thread.

Review commit: https://reviewboard.mozilla.org/r/202276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202276/

Comment 2

[Benjamin Chen [:bechen]]

Comment on attachment 8931191 [details]
Bug 1419666 - MemoryBlockCacheTelemetry::NotifyCombinedSizeGrown() should assert the main thread only for the first call.

https://reviewboard.mozilla.org/r/202276/#review208002

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8931191 [details]
Bug 1419666 - MemoryBlockCacheTelemetry::NotifyCombinedSizeGrown() should assert the main thread only for the first call.

https://reviewboard.mozilla.org/r/202276/#review208004

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b2634540732
MemoryBlockCacheTelemetry::NotifyCombinedSizeGrown() should assert the main thread only for the first call. r=bechen,gerald

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/0b2634540732