1419709 - move a few more static methods out of nsRuleNode.h

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Cameron McCormack (:heycam)]

There are a few nsStyleStructID-related static methods in nsRuleNode.h that need to be moved elsewhere, since we'll want to keep calling them after nsRuleNode is removed.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1419709 - Move a few nsStyleStructID-related static methods out of nsRuleNode.h

Review commit: https://reviewboard.mozilla.org/r/201960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201960/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8930852 [details]
Bug 1419709 - Move a few nsStyleStructID-related static methods out of nsRuleNode.h

https://reviewboard.mozilla.org/r/201960/#review207334

::: layout/style/nsStyleContext.h:295
(Diff revision 1)
>    /**
>     * Start the background image loads for this style context.
>     */
>    inline void StartBackgroundImageLoads();
>  
> +  static bool IsReset(const nsStyleStructID aSID) {

nit: I think braces are supposed to go on their own line.

Comment 3

[Cameron McCormack (:heycam)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #2)
> nit: I think braces are supposed to go on their own line.

They are indeed.  I just copied the lines as is.  But I'll fix this up.

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8930852 [details]
Bug 1419709 - Move a few nsStyleStructID-related static methods out of nsRuleNode.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201960/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14e8c75ef648
Move a few nsStyleStructID-related static methods out of nsRuleNode.h r=emilio

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/14e8c75ef648