Closed Bug 1419709 Opened 4 years ago Closed 4 years ago

move a few more static methods out of nsRuleNode.h

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

There are a few nsStyleStructID-related static methods in nsRuleNode.h that need to be moved elsewhere, since we'll want to keep calling them after nsRuleNode is removed.
Comment on attachment 8930852 [details]
Bug 1419709 - Move a few nsStyleStructID-related static methods out of nsRuleNode.h

https://reviewboard.mozilla.org/r/201960/#review207334

::: layout/style/nsStyleContext.h:295
(Diff revision 1)
>    /**
>     * Start the background image loads for this style context.
>     */
>    inline void StartBackgroundImageLoads();
>  
> +  static bool IsReset(const nsStyleStructID aSID) {

nit: I think braces are supposed to go on their own line.
Attachment #8930852 - Flags: review?(emilio) → review+
(In reply to Emilio Cobos Álvarez [:emilio] from comment #2)
> nit: I think braces are supposed to go on their own line.

They are indeed.  I just copied the lines as is.  But I'll fix this up.
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14e8c75ef648
Move a few nsStyleStructID-related static methods out of nsRuleNode.h r=emilio
https://hg.mozilla.org/mozilla-central/rev/14e8c75ef648
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.