1419782 - [compare-locales] DefinesParser should only take a single whitespace between key and value

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: compare-locales, defect)

Description

[Axel Hecht [:Pike]]

This is a regression from bug 1399059, in .inc files, everything after a single ' ' is the value, notably:

#define foo  

with two trailing spaces defines foo to be ' '.

Comment 1

[Axel Hecht [:Pike]]

Attachment: bug 1419782, .inc files only use one whitespace to separate key and value,

Review commit: https://reviewboard.mozilla.org/r/202056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202056/

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 8930965 [details]
bug 1419782, .inc files only use one whitespace to separate key and value,

https://reviewboard.mozilla.org/r/202056/#review207710

::: compare_locales/tests/test_defines.py:180
(Diff revision 1)
> +        # funny formatting of trailing whitespace to make it explicit
> +        # and flake-8 happy
> +        self._test('''\
> +#define one \n\
> +#define two  \n\
> +#define tre   \n\

I like this "trick" notation!

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8930965 [details]
bug 1419782, .inc files only use one whitespace to separate key and value,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202056/diff/1-2/

Comment 4

[Axel Hecht [:Pike]]

https://hg.mozilla.org/l10n/compare-locales/rev/bcb7487741d704009e9e51111c02734a29e7ba59, FIXED.