Closed Bug 1419899 Opened 4 years ago Closed 3 years ago

implement /__heartbeat__ and /__lbheartbeat__ Dockerflow endpoints

Categories

(Socorro :: Webapp, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

Attachments

(2 files)

Bug #1419856 implemented the /__version__ endpoint, but we need /__heartbeat__ and /__lbheartbeat__ to finish up the Dockerflow bits.

This bug covers implementing those.

One thing we might want to think about is ditch our /__version__ implementation and switch to python-dockerflow and implement all three that way.
Miles reminded me that while it's nice to have these endpoints on the webapp, it's better to have them on all the apps. We should think about that either as part of this bug or as another bug.
Need to implement this for the new infra. Making it a P2.
Priority: -- → P2
We're using existing endpoints for now. I would like to swap those out for more Dockerflow-like ones at some point, but we can do that after we migrate to the new infra.

Given that, I'm unblocking this bug.
No longer blocks: 1391034
Summary: [ops infra socorro] implement /__heartbeat__ and /__lbheartbeat__ endpoints → implement /__heartbeat__ and /__lbheartbeat__ Dockerflow endpoints
These need to be implemented in the webapp, so I'm moving it to that component.
Component: Infra → Webapp
Whiteboard: [good first bug]
Hi Will,

Could I work on this issue?
Flags: needinfo?(willkg)
I originally thought this would be a straight-forward bug since we're just moving around views, but a bunch of stuff has changed since then and I think someone who knows our infrastructure to spend time on this to figure out what defines "unhealthy" and then implement that.

Given that, this isn't a good first bug anymore. I'm nixing it from that status.

Sorry about that!
Flags: needinfo?(willkg)
Whiteboard: [good first bug]
(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #6)
> I originally thought this would be a straight-forward bug since we're just
> moving around views, but a bunch of stuff has changed since then and I think
> someone who knows our infrastructure to spend time on this to figure out
> what defines "unhealthy" and then implement that.
> 
> Given that, this isn't a good first bug anymore. I'm nixing it from that
> status.
> 
> Sorry about that!

Ok! Thanks for your comment.

willkg merged PR #4823: "fix bug 1419899: implement __heartbeat__ and __lbheartbeat__" in 6c49d63.

This just adds these to the webapp. Doing the other services should be covered under a different bug because they're trickier since they don't have web servers.

Pushed to prod in 365. Marking as FIXED.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.