Closed
Bug 1419924
Opened 7 years ago
Closed 7 years ago
Add crossStart position for FlexLines
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: gl, Assigned: bradwerth)
References
Details
(Whiteboard: [designer-tools])
Attachments
(3 files)
DevTools would like to know the crossStart position for FlexLine which is useful when visualizing the FlexLine. We need a computation of the crossStart position because FlexLine can be aligned by justify-content property. See https://www.w3.org/TR/css-flexbox-1/images/align-content-example.svg https://drafts.csswg.org/css-flexbox-1/#flex-lines
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8933805 -
Flags: review?(dholbert)
Attachment #8933806 -
Flags: review?(bugs)
Attachment #8933807 -
Flags: review?(gl)
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8933806 [details] Bug 1419924 Part 2: Add a crossStart property to FlexLine Chrome object. https://reviewboard.mozilla.org/r/204734/#review210558
Attachment #8933806 -
Flags: review?(bugs) → review+
|
Reporter | |
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8933807 [details] Bug 1419924 Part 3: Update tests to check crossStart property. https://reviewboard.mozilla.org/r/204736/#review210766
Attachment #8933807 -
Flags: review?(gl) → review+
Whiteboard: [designer-tools]
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8933805 [details] Bug 1419924 Part 1: Capture FlexLine cross start position to report to devtools when requested. https://reviewboard.mozilla.org/r/204732/#review211206 r=me
Attachment #8933805 -
Flags: review?(dholbert) → review+
|
|
Reporter | |
Comment 7•7 years ago
|
||
I am not sure if this is reporting the correct crossStart for flex-direction: column
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 12•7 years ago
|
||
(In reply to Gabriel [:gl] (ΦωΦ) from comment #7) > I am not sure if this is reporting the correct crossStart for > flex-direction: column I expanded the test add a flex-direction:column case.
|
||
Comment 13•7 years ago
|
||
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c292873bb2b3 Part 1: Capture FlexLine cross start position to report to devtools when requested. r=dholbert https://hg.mozilla.org/integration/autoland/rev/97fa6b7abc0a Part 2: Add a crossStart property to FlexLine Chrome object. r=smaug https://hg.mozilla.org/integration/autoland/rev/890da77f0442 Part 3: Update tests to check crossStart property. r=gl
|
||
Comment 14•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c292873bb2b3 https://hg.mozilla.org/mozilla-central/rev/97fa6b7abc0a https://hg.mozilla.org/mozilla-central/rev/890da77f0442
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•