1419925 - fix clipboard tests to be more reliable

Status: RESOLVED FIXED

(Testing :: Mochitest, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

In bug 1394757 there was a lot of work to get clipboard tests running inside a VM.  While this was solved with disabling the VM clipboard manager, there are updates to the tests which we should land for better stability.

Comment 1

[Neil Deakin]

Attachment: Promise-based clipboard setting for tests

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8931365 [details] [diff] [review]
Promise-based clipboard setting for tests

Review of attachment 8931365 [details] [diff] [review]:
-----------------------------------------------------------------

just a few small nits I found- overall this looks like a healthy cleanup of these tests!

::: browser/components/customizableui/test/browser_947914_button_cut.js
@@ -56,5 @@
>  });
>  
>  registerCleanupFunction(function cleanup() {
>    CustomizableUI.reset();
> -  Services.clipboard.emptyClipboard(globalClipboard);

do we need to empty the clipboard?

::: dom/base/test/test_copypaste.html
@@ +18,5 @@
>  <pre id="test">
>  <script class="testbody" type="text/javascript">
>  
>  SimpleTest.waitForExplicitFinish();
> +SimpleTest.requestCompleteLog();

can we remove the call for complete log?

::: dom/tests/mochitest/general/test_clipboard_events.html
@@ +66,5 @@
>    return SpecialPowers.getClipboardData("text/unicode");
>  }
>  
> +async function putOnClipboard(expected, operationFn, desc, type)
> +{

the other functions in this file have the { on the definition line, not on a new line- we should keep the style the same.

::: testing/mochitest/tests/SimpleTest/SimpleTest.js
@@ +958,5 @@
>                                         aSuccessFn, aFailureFn, aFlavor, aTimeout, aExpectFailure) {
> +    let promise = SimpleTest.promiseClipboardChange(aExpectedStringOrValidatorFn, aSetupFn,
> +                                                    aFlavor, aTimeout, aExpectFailure);
> +    promise.then(function () { info("SUCCESS!\n"); aSuccessFn(); }).
> +            catch(function () { info("FAILED!\n"); aFailureFn(); });

these info() statements could use a bit more context about what is failing or succeeding

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8972884c1ac7
implement a promise-oriented version of waitForClipboard, promiseClipboardChange, change a selection of tests to use this instead. Simplify some other clipboard tests that were unreliable before the fix for 1394757. r=jmaher

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8972884c1ac7