Remove "menu-vertical" binding

RESOLVED FIXED in Firefox 60

Status

()

enhancement
P5
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: bgrins, Assigned: william.loughton)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 wontfix, firefox59 wontfix, firefox60 fixed)

Details

(Whiteboard: [xbl-available])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
The menu-vertical binding is unused in m-c: https://dxr.mozilla.org/mozilla-central/search?q=menu-vertical, so the binding can be removed: https://dxr.mozilla.org/mozilla-central/rev/72ee4800d4156931c89b58bd807af4a3083702bb/toolkit/content/widgets/toolbarbutton.xml#43-59.

It is however used in comm-central so the binding will need to be migrated there to continue working: https://dxr.mozilla.org/comm-central/search?q=menu-vertical.
(Reporter)

Updated

a year ago
See Also: → 354616

Updated

a year ago
Priority: -- → P5

Updated

a year ago
Keywords: good-first-bug
(Assignee)

Comment 1

a year ago
Posted patch 1419932.patchSplinter Review
Attachment #8944571 - Flags: review?(bgrinstead)
(Reporter)

Comment 2

a year ago
Comment on attachment 8944571 [details] [diff] [review]
1419932.patch

Review of attachment 8944571 [details] [diff] [review]:
-----------------------------------------------------------------

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=283d4139c91f025c6d0f061d1c2b6410d8bb961b
Attachment #8944571 - Flags: review?(bgrinstead) → review+
(Reporter)

Updated

a year ago
Assignee: nobody → william.loughton
Status: NEW → ASSIGNED

Updated

a year ago
Depends on: 1432534

Comment 4

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1243fb53ab9
Remove unused menu-vertical binding in toolbarbutton. r=bgrins
Keywords: checkin-needed

Updated

a year ago
Depends on: 1432561

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b1243fb53ab9
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.