Closed Bug 1419932 Opened 4 years ago Closed 3 years ago

Remove "menu-vertical" binding

Categories

(Toolkit :: XUL Widgets, task, P5)

Product:
Toolkit
Component:
XUL Widgets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox58 --- wontfix
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: bgrins, Assigned: william.loughton)

References

Details

(Keywords: good-first-bug, Whiteboard: [xbl-available])

Attachments

(1 file)

1419932.patch
1.66 KB, patch
bgrins
: review+
Details | Diff | Splinter Review 
The menu-vertical binding is unused in m-c: https://dxr.mozilla.org/mozilla-central/search?q=menu-vertical, so the binding can be removed: https://dxr.mozilla.org/mozilla-central/rev/72ee4800d4156931c89b58bd807af4a3083702bb/toolkit/content/widgets/toolbarbutton.xml#43-59.

It is however used in comm-central so the binding will need to be migrated there to continue working: https://dxr.mozilla.org/comm-central/search?q=menu-vertical.
See Also: → 354616
status-firefox58: --- → wontfix
status-firefox59: --- → fix-optional
Priority: -- → P5
Keywords: good-first-bug
Attached patch 1419932.patch — — Splinter Review
Attachment #8944571 - Flags: review?(bgrinstead)
Comment on attachment 8944571 [details] [diff] [review]
1419932.patch

Review of attachment 8944571 [details] [diff] [review]:
-----------------------------------------------------------------

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=283d4139c91f025c6d0f061d1c2b6410d8bb961b
Attachment #8944571 - Flags: review?(bgrinstead) → review+
Assignee: nobody → william.loughton
Status: NEW → ASSIGNED
Depends on: 1432534
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1243fb53ab9
Remove unused menu-vertical binding in toolbarbutton. r=bgrins
Keywords: checkin-needed
Depends on: 1432561
https://hg.mozilla.org/mozilla-central/rev/b1243fb53ab9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.