Closed Bug 1420037 Opened 2 years ago Closed 2 years ago

Spew of Intermittent PID 2688 | TypeError: this.dataProvider is null: listener@resource://devtools/shared/base-loader.js -> resource://devtools/client/netmonitor/src/connector/firefox-connector.js:132:11 obscures TEST-UNEXPECTED-ERROR | tps | timeout

Categories

(DevTools :: Netmonitor, defect, P5)

defect

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ochameau)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=146833754&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32/mozilla-inbound_win7_ix_test-g2-e10s-bm111-tests1-windows-build1628.txt.gz

Your choice which to fix: if the suite wasn't timing out, I wouldn't see the spew of treeherder-false-positives, or if there wasn't such a huge spew of false-positives, I'd probably wind up refiling the suite timeout as a talos bug.
Blocks: 1411889
Component: Developer Tools → Developer Tools: Netmonitor
Assignee: nobody → poirot.alex
Thanks for the report Phil. I'm going to address the exceptions here.
The timeout is related to tps test suite, which I do not know about.

Honza, the first patch should fix the exception, while the second would also fix it by better waiting for netmonitor full completion during requestsFinished subtest.
The second patch increase simple.requestsFinished by 40%!
https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&newProject=try&newRevision=a758e445b31ba968b91dbf88c81b2c7e635ffdeb&originalSignature=edaec66500db21d37602c99daa61ac983f21a6ac&newSignature=edaec66500db21d37602c99daa61ac983f21a6ac&framework=1&selectedTimeRange=172800
This is expected, as before we weren't correctly waiting.
But I would have expected to also see a bump in complicated.requestsFinished, wheres it is unchanged...
Comment on attachment 8931273 [details]
Bug 1420037 - Fix netmonitor "dataProvider is null" exception on DAMP.

https://reviewboard.mozilla.org/r/202426/#review207812

Looks good, thanks!

Honza
Attachment #8931273 - Flags: review?(odvarko) → review+
Comment on attachment 8931274 [details]
Bug 1420037 - Wait for all payload to be finished in DAMP requestsFinished.

https://reviewboard.mozilla.org/r/202428/#review207814

Yep, I lik this patch!
R+
Honza
Attachment #8931274 - Flags: review?(odvarko) → review+
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9ea3f389c6a
Fix netmonitor "dataProvider is null" exception on DAMP. r=Honza
https://hg.mozilla.org/integration/autoland/rev/adec56d3dad5
Wait for all payload to be finished in DAMP requestsFinished. r=Honza
https://hg.mozilla.org/mozilla-central/rev/f9ea3f389c6a
https://hg.mozilla.org/mozilla-central/rev/adec56d3dad5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.