1420037 - Spew of Intermittent PID 2688 | TypeError: this.dataProvider is null: listener@resource://devtools/shared/base-loader.js -> resource://devtools/client/netmonitor/src/connector/firefox-connector.js:132:11 obscures TEST-UNEXPECTED-ERROR | tps | timeout

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=146833754&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32/mozilla-inbound_win7_ix_test-g2-e10s-bm111-tests1-windows-build1628.txt.gz

Your choice which to fix: if the suite wasn't timing out, I wouldn't see the spew of treeherder-false-positives, or if there wasn't such a huge spew of false-positives, I'd probably wind up refiling the suite timeout as a talos bug.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1420037 - Fix netmonitor "dataProvider is null" exception on DAMP.

Review commit: https://reviewboard.mozilla.org/r/202426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202426/

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1420037 - Wait for all payload to be finished in DAMP requestsFinished.

Review commit: https://reviewboard.mozilla.org/r/202428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202428/

Comment 3

[Alexandre Poirot [:ochameau]]

Thanks for the report Phil. I'm going to address the exceptions here.
The timeout is related to tps test suite, which I do not know about.

Honza, the first patch should fix the exception, while the second would also fix it by better waiting for netmonitor full completion during requestsFinished subtest.

Comment 4

[Alexandre Poirot [:ochameau]]

The second patch increase simple.requestsFinished by 40%!
https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&newProject=try&newRevision=a758e445b31ba968b91dbf88c81b2c7e635ffdeb&originalSignature=edaec66500db21d37602c99daa61ac983f21a6ac&newSignature=edaec66500db21d37602c99daa61ac983f21a6ac&framework=1&selectedTimeRange=172800
This is expected, as before we weren't correctly waiting.
But I would have expected to also see a bump in complicated.requestsFinished, wheres it is unchanged...

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8931273 [details]
Bug 1420037 - Fix netmonitor "dataProvider is null" exception on DAMP.

https://reviewboard.mozilla.org/r/202426/#review207812

Looks good, thanks!

Honza

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8931274 [details]
Bug 1420037 - Wait for all payload to be finished in DAMP requestsFinished.

https://reviewboard.mozilla.org/r/202428/#review207814

Yep, I lik this patch!
R+
Honza

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9ea3f389c6a
Fix netmonitor "dataProvider is null" exception on DAMP. r=Honza
https://hg.mozilla.org/integration/autoland/rev/adec56d3dad5
Wait for all payload to be finished in DAMP requestsFinished. r=Honza

Comment 8

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/f9ea3f389c6a
https://hg.mozilla.org/mozilla-central/rev/adec56d3dad5

Comment 9

[Intermittent Failures Robot]

21 failures in 744 pushes (0.028 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 9
* mozilla-inbound: 8
* mozilla-central: 4

Platform breakdown:
* linux64: 17
* windows7-32: 3
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1420037&startday=2017-11-20&endday=2017-11-26&tree=all