1420061 - Large and duplicated window control buttons if titlebar is visible on MacOS

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: screenshot

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20171120222519

If the title bar gets enabled in Customize toolbars, the window control buttons appear twice. As expected in the titlebar, but then also as duplicates with a really huge size laying over the tab and title bar. See the screenshot for an example.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So this behavior sticks until Firefox gets restarted, and can easily be reproduced again when flipping the checkbox twice in customize toolbar.

Also it is only visible with WebRender enabled.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1420061 - Don't duplicate window controls when titlebar is enabled.

This copies over the early-exit conditions from MaybeDrawTitlebar which
is the non-WR codepath where this gets drawn. In particular, the
!mIsCoveringTitlebar clause is true when the titlebar is enabled.

Review commit: https://reviewboard.mozilla.org/r/260448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260448/

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8996297 [details]
Bug 1420061 - Don't duplicate window controls when titlebar is enabled.

https://reviewboard.mozilla.org/r/260448/#review267562

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18f39664639a
Don't duplicate window controls when titlebar is enabled. r=mstange

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/18f39664639a

Comment 7

[Cristian Fogel [:cfogel]]

Based on the fact that the Webrender is disabled on beta, removing the QE flag.