Closed
Bug 1420076
Opened 6 years ago
Closed 6 years ago
Permanent false-positive /streams/readable-byte-streams/detached-buffers.dedicatedworker.html | application crashed [@ TransferArrayBuffer]
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | wontfix |
firefox60 | --- | fixed |
firefox61 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: jorendorff)
References
Details
(Keywords: crash, intermittent-failure)
Crash Data
Attachments
(1 file)
Filed by: csabou [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=146811803&repo=mozilla-central https://queue.taskcluster.net/v1/task/aIWC-SPhQLOkp6eI_2Fu8Q/runs/0/artifacts/public/logs/live_backing.log
Updated•6 years ago
|
Summary: Intermittent /streams/readable-byte-streams/detached-buffers.dedicatedworker.html | application crashed [@ TransferArrayBuffer] → Permanent false-positive /streams/readable-byte-streams/detached-buffers.dedicatedworker.html | application crashed [@ TransferArrayBuffer]
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 5•6 years ago
|
||
On debug runs, there's also an assertion coming along for the ride: Assertion failure: !JS_IsDetachedArrayBufferObject(buffer), at z:/build/build/src/js/src/builtin/Stream.cpp:5141 Till, can you please take a look at this?
Component: web-platform-tests → JavaScript Engine
Flags: needinfo?(till)
Product: Testing → Core
See Also: → 1424549
Version: Version 3 → unspecified
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 22•6 years ago
|
||
Disabling this and the other worker variants on Windows since for some reason the trees are orange, even though the failures are "expected". In any case I expect we should fix the underlying assert here since that's a real bug.
Comment 23•6 years ago
|
||
I also bundled in disabling the construct-byob-request*.html crashes on Windows, since they seem to be probably the same bug.
Comment 24•6 years ago
|
||
Dunno why this was set to P5, but a reproducable assert/crash seems like it should be properly triaged.
Priority: P5 → --
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 27•6 years ago
|
||
Jason, this looks like a 100% reproducible crash we're hitting in web-platform-tests. Can you maybe help find an owner for it?
Flags: needinfo?(jorendorff)
Assignee | ||
Comment 28•6 years ago
|
||
<till> jorendorff: we should just disable it, because byte streams go away with the patch you're reviewing
Assignee | ||
Comment 29•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f779bbf22917aa58fc80881714fbdb5caa8894e
Assignee | ||
Comment 30•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=92147685f586c3f5183043d51f2e191fe1529a5d
Assignee | ||
Comment 31•6 years ago
|
||
Attachment #8968656 -
Flags: review?(till)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Comment 32•6 years ago
|
||
Comment on attachment 8968656 [details] [diff] [review] Fix permanent crash [@ TransferArrayBuffer] in /streams/readable-byte-streams/detached-buffers.dedicatedworker.html Review of attachment 8968656 [details] [diff] [review]: ----------------------------------------------------------------- rs=me, thank you for doing this!
Attachment #8968656 -
Flags: review?(till) → review+
Updated•6 years ago
|
Flags: needinfo?(till)
Flags: needinfo?(jorendorff)
Assignee | ||
Comment 33•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/405a7e528aeb6194cac28b860e2b2cc15a7b4738 Bug 1420076 - Fix permanent crash [@ TransferArrayBuffer] in /streams/readable-byte-streams/detached-buffers.dedicatedworker.html. r=till.
Comment 34•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/405a7e528aeb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
Whiteboard: [checkin-needed-beta]
Comment 35•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/349a3bd7971a
status-firefox60:
--- → fixed
Whiteboard: [checkin-needed-beta]
Updated•6 years ago
|
status-firefox59:
--- → wontfix
status-firefox-esr52:
--- → unaffected
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•