Closed Bug 1420106 Opened 7 years ago Closed 7 years ago

Undo Closing All Tabs XCUITests are failing due to the missing option to 'Undo'

Categories

(Firefox for iOS :: Build & Test, defect)

Other
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios 11.0 ---

People

(Reporter: isabel_rios, Assigned: farhan)

References

Details

(Keywords: regression)

Attachments

(1 file)

The test affected is: testCloseAllTabsUndo() which belongs to TopTabs Test suite. It fails for both iPhone and iPad sim. Steps: -Open 4 Tabs -Go to tab tray and tap on Remove icon -Tap on Close all tabs -Wait to see there is a 'Undo' banner and tap on it Expected: Undo option appears and the tabs just closed are restored Actual: There is no 'Undo' option Not sure if this has changed by design or is a regression.
This is happening in latest master: 9c3a64593dbc1aa5c406e057cc14bba081e0da80 Seems like the commit from which it started to happen is: f806a393feadd6326c10c03cb12bdd64d3b7b1bb Bug 1417671 - Rewrite a few view layouts using UIStackview Could you please confirm whether this has been removed or is a regression? Thanks!
Flags: needinfo?(fpatel)
Keywords: regression
See Also: → 1420890
Attached file Pull Request
Flags: needinfo?(fpatel)
Attachment #8932144 - Flags: review?(jdarcangelo)
Assignee: nobody → fpatel
Attachment #8932144 - Flags: review?(jdarcangelo) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: