Closed Bug 1420129 Opened 2 years ago Closed 2 years ago

Clicking the 'Settings page' link on about:searchreset should go directly to the Search pref pane

Categories

(Firefox :: Search, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- verified
firefox58 --- verified
firefox59 --- verified

People

(Reporter: florian, Assigned: florian)

References

Details

(Keywords: regression)

Attachments

(1 file)

This was changed in bug 1335907 that removed the search panel, before it got re-added later (likely in bug 1365133).
Assignee: nobody → florian
Status: NEW → ASSIGNED
QA Contact: adrian.florinescu
Comment on attachment 8931316 [details] [diff] [review]
Patch

Review of attachment 8931316 [details] [diff] [review]:
-----------------------------------------------------------------

Tested by inspecting the link in about:searchreset and changing the URL manually. Also, there's a test[1] that opens about:preferences#search and does stuff with the UI, which gives me confidence that this is sane to do.

[1] https://searchfox.org/mozilla-central/rev/33c90c196bc405e628bc868a4f4ba29b992478c0/browser/components/preferences/in-content/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.js#44
Attachment #8931316 - Flags: review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9e5bc0c80e8
Clicking the 'Settings page' link on about:searchreset should go directly to the Search pref pane, r=nhnt11.
Comment on attachment 8931316 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1335907 and/or bug 1365133
[User impact if declined]: about:searchreset will point users to the general pane of the preferences page
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: Yes
[List of other uplifts needed for the feature/fix]: bug 1419941
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial, covered by test
[String changes made/needed]: none
Attachment #8931316 - Flags: approval-mozilla-release?
Attachment #8931316 - Flags: approval-mozilla-beta?
Comment on attachment 8931316 [details] [diff] [review]
Patch

Needed for 57.
Attachment #8931316 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/mozilla-central/rev/a9e5bc0c80e8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Marking as verified on 58.0b6 - 2017/11/23  on Ubuntu 14.04x32 & Windows 10 x64 & Mac OsX10.12:
- the 'Settings page' link on about:searchreset redirects to about:preferences#search.
Attachment #8931316 - Flags: approval-mozilla-release? → approval-mozilla-release+
verified also on Nightly  -> 59.0a1 20171126220311
Verified fixed on Windows 7 x64, Windows 10 x64, macOS 10.13 and Ubuntu 14.04 x64 using Firefox 57.0.1 (buildID: 20171128222554).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.