Closed Bug 1420146 Opened 8 years ago Closed 8 years ago

Bookmarks Menu button in overflow menu is missing bookmarks and folders

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: gingerbread_man, Unassigned)

Details

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0 20171122220056 1. Start Firefox in a brand new profile. 2. Right-click one of the toolbar buttons on the right and choose Customize. 3. Drag the "Bookmarks Menu" button from the customization palette into the overflow menu. Click Done when finished. 4. Click the overflow menu chevron, then the Bookmarks Menu button. Actual results: The bookmarks menu in the overflow menu is missing most bookmarks and folders. It only shows "Bookmark This Page", "Bookmarking Tools", "Search Bookmarks", the "Recently Bookmarked" category, and the "Show All Bookmarks" button. Expected results: The bookmarks menu in the overflow menu should show all bookmarks and folders, including "Bookmarks Toolbar", "Other Bookmarks", "Recent Tags", etc.
Is this intended behavior? This is how the Library button behaves, whether it's in the overflow menu or not. Based on the summary of bug 1352110, I take it that behavior is actually intentional. Correct?
Has STR: --- → yes
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Gingerbread Man from comment #1) > Is this intended behavior? > > This is how the Library button behaves, whether it's in the overflow menu or > not. Based on the summary of bug 1352110, I take it that behavior is > actually intentional. Correct? Yes. See also bug 1389625 where I was also a bit concerned about exactly this confusion. We discussed with UX and decided to ship this as-is for now. We're evaluating user confusion over the library / bookmarks menu/toolbar thing generally (cf. bug 1415692, bug 1417523 comment 3), and we might revisit this as part of that change. But basically, there's 1 panelview that deals with bookmarks, and it was updated for the library. That panelview is also what gets used if the bookmarks menu button is in the overflow panel. I don't think this (in?)consistency in and of itself is worth really addressing (like, implementing the same thing twice is just a bit silly), but we might do something more drastic like implementing folders in the library in the end anyway, which would also fix this bug. So I'm going to close this out, but we *are* looking at this stuff. Feel free to ping me if, come 2018, there hasn't been more movement on nightly to address some of this.
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(gijskruitbosch+bugs)
Resolution: --- → INVALID
(and to be clear, for various technical reasons the thing that shows up when opening the bookmarks menu from the toolbar is already a separate thing, but can't easily be reused for the library or inside the overflow menu. See also e.g. bug 985024. The entire thing is a bit sad, and we hope to do something soon... :-( )
OK, thank you very much. It's that user confusion that lead me to ask. http://forums.mozillazine.org/viewtopic.php?f=9&t=3035761

Feel free to ping me if, come 2018, there hasn't been more movement on nightly to address some of this.

Well it's 2021 and this bug is still present, so can this bug be reopened?

The current behaviour completely breaks the ability to open sets of bookmarks (either a folder, or a specific tag) from the bookmarks button, when it's in the overflow menu.

When it's outside of the overflow menu, a tag or folder can be middle-clicked (or right-clicked + "open all") to open a set of bookmarks.

You need to log in before you can comment on or make changes to this bug.