1420201 - New XCUITest: Close tab from Page Options menu and long press tabs tray menu

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Isabel Rios[:isabel_rios]]

A new Close tab option has been added to Page Options menu and long press tabs tray menu.
This test aims to test those scenarios.

These options are implemented in v10.x and master

Comment 1

[Isabel Rios[:isabel_rios]]

See bug: 1416820

Comment 2

[Isabel Rios[:isabel_rios]]

Attachment: Pull Request

Comment 3

[Isabel Rios[:isabel_rios]]

Comment on attachment 8932439 [details] [review]
Pull Request

Asking for r? , tests are green, execpt for one not related which is a regression and is being fixed.

https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5a1d57fb8dc41b00018bc033#tests

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8932439 [details] [review]
Pull Request

Looking good. A few changes in the PR needed.

Comment 5

[Isabel Rios[:isabel_rios]]

Comment on attachment 8932439 [details] [review]
Pull Request

Thanks for the comments on the PR, I made the changes to try to fix them. Please take a look at it when you have some time. Thanks!

Comment 6

[Isabel Rios[:isabel_rios]]

Merged: https://github.com/mozilla-mobile/firefox-ios/commit/4e41bee2e9c4085e2d0694ca7a60eb56d9aeae4e