1420320 - Drop dom.animations-api.pending-member.enabled pref

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement, P3)

Description

[Brian Birtles (:birtles, Feb 26~ parental leave)]

This pref was only introduced in case we encountered compatibility issues. Once bug 1412765 has reached release (i.e. once we hit Firefox 59) it's probably ok to drop the pref.

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Patch

This will no doubt bitrot before it's ready to land but hopefully this at least serves as a reminder of the places we need to fix.

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf262321a584e41b0eda3bbbe905b58d6e69dffd

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1420320 - Drop dom.animations-api.pending-member.enabled pref;

Review commit: https://reviewboard.mozilla.org/r/228230/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228230/

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8959411 [details]
Bug 1420320 - Drop dom.animations-api.pending-member.enabled pref;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228230/diff/1-2/

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8959411 [details]
Bug 1420320 - Drop dom.animations-api.pending-member.enabled pref;

https://reviewboard.mozilla.org/r/228230/#review234062

::: dom/animation/test/chrome/test_animation_observers_async.html:582
(Diff revision 2)
>  setup({explicit_done: true});
>  
> -SpecialPowers.pushPrefEnv(
> +runTest();
> -  { set: [["dom.animations-api.pending-member.enabled", true]] }
> -).then(runTest).then(() => {
> -  done();
> +done();

I wonder we can drop setup({explicit:done: true}) and done()?

Comment 6

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8959411 [details]
Bug 1420320 - Drop dom.animations-api.pending-member.enabled pref;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228230/diff/2-3/

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8959411 [details]
Bug 1420320 - Drop dom.animations-api.pending-member.enabled pref;

https://reviewboard.mozilla.org/r/228230/#review234066

r=me on the webidl bits

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15cdfea58186
Drop dom.animations-api.pending-member.enabled pref; r=bz,hiro

Comment 9

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/15cdfea58186