Closed Bug 1420320 Opened 2 years ago Closed 2 years ago

Drop dom.animations-api.pending-member.enabled pref

Categories

(Core :: DOM: Animation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox59 --- wontfix
firefox60 --- wontfix
firefox61 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

Attachments

(1 file, 1 obsolete file)

This pref was only introduced in case we encountered compatibility issues. Once bug 1412765 has reached release (i.e. once we hit Firefox 59) it's probably ok to drop the pref.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Priority: -- → P3
Attached patch Patch (obsolete) — Splinter Review
This will no doubt bitrot before it's ready to land but hopefully this at least serves as a reminder of the places we need to fix.
Attachment #8931564 - Attachment is obsolete: true
Comment on attachment 8959411 [details]
Bug 1420320 - Drop dom.animations-api.pending-member.enabled pref;

https://reviewboard.mozilla.org/r/228230/#review234062

::: dom/animation/test/chrome/test_animation_observers_async.html:582
(Diff revision 2)
>  setup({explicit_done: true});
>  
> -SpecialPowers.pushPrefEnv(
> +runTest();
> -  { set: [["dom.animations-api.pending-member.enabled", true]] }
> -).then(runTest).then(() => {
> -  done();
> +done();

I wonder we can drop setup({explicit:done: true}) and done()?
Attachment #8959411 - Flags: review?(hikezoe) → review+
Comment on attachment 8959411 [details]
Bug 1420320 - Drop dom.animations-api.pending-member.enabled pref;

https://reviewboard.mozilla.org/r/228230/#review234066

r=me on the webidl bits
Attachment #8959411 - Flags: review?(bzbarsky) → review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15cdfea58186
Drop dom.animations-api.pending-member.enabled pref; r=bz,hiro
https://hg.mozilla.org/mozilla-central/rev/15cdfea58186
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.