Closed Bug 1420324 Opened 2 years ago Closed 2 years ago
Bad things could happen when Media
Block Cache Base::Read() is called without holding the Media Cache monitor
https://searchfox.org/mozilla-central/rev/a5d613086ab4d0578510aabe8653e58dc8d7e3e2/dom/media/MediaCache.cpp#784-790 1. The cache blocks might be evicted, moved, or tampered when blockCache->Read() is called without holding the cache monitor. This might explain the decode errors seen in bug 1404373 comment 14. 2. https://searchfox.org/mozilla-central/rev/a5d613086ab4d0578510aabe8653e58dc8d7e3e2/dom/media/MediaCache.cpp#2571 cacheBlock might become an invalid index after mMediaCache->ReadCacheFile() returns for the reason described above.
Assignee: nobody → jwwang
Priority: -- → P2
This is bug is fixed by bug 1428242 P2 which remove unlock in MediaCache::ReadCacheFile().
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1428242
You need to log in before you can comment on or make changes to this bug.