Closed
Bug 1420330
Opened 7 years ago
Closed 7 years ago
./mach bootstrap is incomplete on FreeBSD
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: jbeich, Assigned: jbeich)
Details
(Whiteboard: [npotb])
Attachments
(1 file)
$ pkg install python27 $ ./mach bootstrap $ ./mach build [...] 0:13.98 checking for yasm... /usr/local/bin/yasm 0:14.01 checking yasm version... 1.3.0 [...] 0:21.26 configure: error: Building ICU requires either yasm or a GNU assembler. If you do not have either of those available for this platform you must use --without-intl-api $ ./mach run 'http://example.com/' Error running mach: ['run', 'http://example.com/'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: ImportError: No module named _sqlite3 File "/tmp/mozilla-central/python/mozbuild/mozbuild/mach_commands.py", line 1354, in run from mozprofile import Profile, Preferences File "/tmp/mozilla-central/build/mach_bootstrap.py", line 364, in __call__ module = self._original_import(name, globals, locals, fromlist, level) File "/tmp/mozilla-central/testing/mozbase/mozprofile/mozprofile/__init__.py", line 17, in <module> from mozprofile.cli import * File "/tmp/mozilla-central/build/mach_bootstrap.py", line 364, in __call__ module = self._original_import(name, globals, locals, fromlist, level) File "/tmp/mozilla-central/testing/mozbase/mozprofile/mozprofile/cli.py", line 18, in <module> from .profile import FirefoxProfile File "/tmp/mozilla-central/build/mach_bootstrap.py", line 364, in __call__ module = self._original_import(name, globals, locals, fromlist, level) File "/tmp/mozilla-central/testing/mozbase/mozprofile/mozprofile/profile.py", line 15, in <module> from .permissions import Permissions File "/tmp/mozilla-central/build/mach_bootstrap.py", line 364, in __call__ module = self._original_import(name, globals, locals, fromlist, level) File "/tmp/mozilla-central/testing/mozbase/mozprofile/mozprofile/permissions.py", line 14, in <module> import sqlite3 File "/tmp/mozilla-central/build/mach_bootstrap.py", line 364, in __call__ module = self._original_import(name, globals, locals, fromlist, level) File "/usr/local/lib/python2.7/sqlite3/__init__.py", line 24, in <module> from dbapi2 import * File "/tmp/mozilla-central/build/mach_bootstrap.py", line 364, in __call__ module = self._original_import(name, globals, locals, fromlist, level) File "/usr/local/lib/python2.7/sqlite3/dbapi2.py", line 28, in <module> from _sqlite3 import * File "/tmp/mozilla-central/build/mach_bootstrap.py", line 364, in __call__ module = self._original_import(name, globals, locals, fromlist, level)
Comment hidden (mozreview-request) |
Can someone clarify why ICU needs GNU as? I don't see it used on aarch64 downstream: http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p454157_s325785/logs/icu-60.1,1.log http://thunderx1.nyi.freebsd.org/data/110arm64-quarterly/451654/logs/icu-59.1,1.log
Can someone clarify why bundled ICU needs yasm? I don't see it used on x86 and x86_64 downstream: http://beefy5.nyi.freebsd.org/data/103i386-default/454296/logs/icu-60.1,1.log http://beefy6.nyi.freebsd.org/data/103amd64-default/454296/logs/icu-60.1,1.log http://beefy1.nyi.freebsd.org/data/110i386-quarterly/454247/logs/icu-59.1,1.log http://beefy2.nyi.freebsd.org/data/103amd64-quarterly/454247/logs/icu-59.1,1.log
Nevermind, bug 1239083 added asm dependency. I still don't understand why *both* yasm and GNU as are required. Nothing else uses yasm on non-x86 archs.
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8931566 [details] Bug 1420330 - FreeBSD bootstrap: add aarch64 and testing dependencies. https://reviewboard.mozilla.org/r/202688/#review208190 You have a legit flake8 error (see https://treeherder.mozilla.org/#/jobs?repo=try&revision=22b8ac956fcc&selectedJob=147328343) that you'll need to address before landing, but this looks fine to me. Thanks!
Attachment #8931566 -
Flags: review+
Updated•7 years ago
|
Attachment #8931566 -
Flags: review?(core-build-config-reviews)
Comment hidden (mozreview-request) |
Comment on attachment 8931566 [details] Bug 1420330 - FreeBSD bootstrap: add aarch64 and testing dependencies. https://reviewboard.mozilla.org/r/202688/#review208190 > You have a legit flake8 error OK. Grouped non-Mozilla imports together.
Hmm, either MozReview couldn't figure out :nalexander is part of :Build or r+ with changes is no longer allowed.
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8931566 [details] Bug 1420330 - FreeBSD bootstrap: add aarch64 and testing dependencies. https://reviewboard.mozilla.org/r/202688/#review210368 Thanks for getting to this, Jan! Much appreciated.
Attachment #8931566 -
Flags: review+
Updated•7 years ago
|
Attachment #8931566 -
Flags: review?(core-build-config-reviews)
Comment 10•7 years ago
|
||
(In reply to Jan Beich from comment #8) > Hmm, either MozReview couldn't figure out :nalexander is part of :Build or > r+ with changes is no longer allowed. There's a weirdness with the handling of the shared queue, MozReview, and Bugzilla. Well, many weirdnesses, but one is that none of the tools understand the aggregate queue.
Updated•7 years ago
|
Assignee: nobody → jbeich
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 11•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e165394929f7 FreeBSD bootstrap: add aarch64 and testing dependencies. r=nalexander
Keywords: checkin-needed
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e165394929f7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•